jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369596 )

Change subject: Removed type hint
......................................................................


Removed type hint

The explicit type hint broke "Extension:PageForms" functionality

NEEDS CHERRY-PICK TO REL1_27

Change-Id: I6bc6640768cb1220740bcac6fb21652dc63a8d27
---
M src/Hooks/UploadFormBeforeProcessing.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Robert Vogel: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/Hooks/UploadFormBeforeProcessing.php 
b/src/Hooks/UploadFormBeforeProcessing.php
index 6f91816..1a3c408 100644
--- a/src/Hooks/UploadFormBeforeProcessing.php
+++ b/src/Hooks/UploadFormBeforeProcessing.php
@@ -41,9 +41,9 @@
         * See static method "handle"
         * @param \IContextSource $context
         * @param \Config $config
-        * @param \SpecialUpload $uploadForm
+        * @param \SpecialUpload $uploadForm 'Extension:PageForms' fires this 
hook with \PFUploadWindow as parameter
         */
-       public function __construct( \IContextSource $context, \Config $config, 
\SpecialUpload $uploadForm ) {
+       public function __construct( \IContextSource $context, \Config $config, 
/* \SpecialUpload */ $uploadForm ) {
                $this->context = $context;
                $this->config = $config;
                $this->uploadForm = $uploadForm;

-- 
To view, visit https://gerrit.wikimedia.org/r/369596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6bc6640768cb1220740bcac6fb21652dc63a8d27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NSFileRepo
Gerrit-Branch: REL1_27
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to