jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/369427 )
Change subject: Add `clearfix` to some blocks to make markup more predictable
......................................................................
Add `clearfix` to some blocks to make markup more predictable
Change-Id: I5ccec42eac4e77c6712418c7a7e6028a36008479
---
M resources/lexeme.less
1 file changed, 23 insertions(+), 14 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/lexeme.less b/resources/lexeme.less
index 8b45ade..4a6bbd9 100644
--- a/resources/lexeme.less
+++ b/resources/lexeme.less
@@ -1,3 +1,11 @@
+.clearfix() {
+ &::after {
+ content: "";
+ display: table;
+ clear: both;
+ }
+}
+
.wb-lexemepage #firstHeading {
display: none;
}
@@ -63,6 +71,10 @@
font-size: 1.2em;
}
+.wikibase-lexeme-forms-section {
+ .clearfix;
+}
+
.wikibase-lexeme-forms-section > .wikibase-toolbar-container {
position: static;
float: left;
@@ -81,14 +93,11 @@
flex-grow: 1;
}
-.wikibase-lexeme-form .wikibase-statementgrouplistview::after,
-.wikibase-lexeme-form .wikibase-listview::after,
-.wikibase-lexeme-form .wikibase-addtoolbar::after {
- /* This is clearfix */
- /* TODO: Should be done in Wikibase for all elements */
- content: "";
- display: table;
- clear: both;
+
+.wikibase-lexeme-form .wikibase-statementgrouplistview,
+.wikibase-lexeme-form .wikibase-listview,
+.wikibase-lexeme-form .wikibase-addtoolbar {
+ .clearfix;
}
.wb-lexeme {
@@ -108,18 +117,18 @@
clear: left;
}
+.wikibase-lexeme-senses-section {
+ .clearfix;
+}
+
.wikibase-lexeme-senses-section > .wikibase-toolbar-container {
position: static;
float: left;
}
-.wikibase-lexeme-sense .wikibase-statementgrouplistview::after {
- /* This is clearfix */
- /* TODO: Should be done in Wikibase for all elements */
- content: "";
- display: table;
- clear: both;
+.wikibase-lexeme-sense .wikibase-statementgrouplistview {
+ .clearfix;
}
.wikibase-lexeme-sense-id {
--
To view, visit https://gerrit.wikimedia.org/r/369427
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ccec42eac4e77c6712418c7a7e6028a36008479
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
