Robert Vogel has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369637 )
Change subject: BSExtendedSearch: Fixed pseudo protocol issue with external
files
......................................................................
BSExtendedSearch: Fixed pseudo protocol issue with external files
This stops the indexing process to crash if users link to resources
that can not be handled by SplFileInfo
Change-Id: I9c9a861860fb91afe504b59efdc72ea463b2db76
---
M ExtendedSearch/includes/BuildIndex/BuildIndexMwLinked.class.php
1 file changed, 10 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/37/369637/1
diff --git a/ExtendedSearch/includes/BuildIndex/BuildIndexMwLinked.class.php
b/ExtendedSearch/includes/BuildIndex/BuildIndexMwLinked.class.php
index ace6401..ee9a3da 100644
--- a/ExtendedSearch/includes/BuildIndex/BuildIndexMwLinked.class.php
+++ b/ExtendedSearch/includes/BuildIndex/BuildIndexMwLinked.class.php
@@ -92,7 +92,16 @@
$path = urldecode( $document->el_to );
$path = str_replace( "file:///", "", $path );
$fileInfo = new SplFileInfo( $path );
- if ( !$fileInfo->isFile() ) continue;
+
+ //As we index all kinds of user provided urls here
there might be
+ //cases that break SplFileInfo (e.g. 'onenote:' pseudo
protocol)
+ try {
+ if ( !$fileInfo->isFile() ) continue;
+ }
+ catch( Exception $e ) {
+ wfDebugLog( 'ExtendedSearch', __METHOD__.':
'.$e->getMessage() );
+ continue;
+ }
$filename = explode( '/', $path );
$filename = array_pop( $filename );
--
To view, visit https://gerrit.wikimedia.org/r/369637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c9a861860fb91afe504b59efdc72ea463b2db76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
