Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53876
Change subject: Add ownership statement to photo upload interface
......................................................................
Add ownership statement to photo upload interface
This makes it clearer to the user that they need to own the image
Change-Id: Ia8e4e52a3beab8700553b49e2683d1a6c624dc84
---
M MobileFrontend.i18n.php
M MobileFrontend.php
M javascripts/modules/mf-photo.js
M less/modules/mf-photo.less
M stylesheets/modules/mf-photo.css
5 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/76/53876/1
diff --git a/MobileFrontend.i18n.php b/MobileFrontend.i18n.php
index 0b3be89..64286f2 100644
--- a/MobileFrontend.i18n.php
+++ b/MobileFrontend.i18n.php
@@ -229,6 +229,7 @@
'mobile-frontend-photo-upload-comment' => 'Added photo to page',
'mobile-frontend-photo-caption-placeholder' => 'Add a description
(required)',
'mobile-frontend-image-loading' => 'Loading image',
+ 'mobile-frontend-image-ownership' => 'I, $1 created this image',
'mobile-frontend-image-uploading-wait' => 'Uploading image, please
wait.',
'mobile-frontend-image-uploading-long' => 'Image still uploading!
Thanks for your patience.',
'mobile-frontend-image-uploading-cancel' => '<a href="#">Cancel</a> if
this is taking too long.',
@@ -497,6 +498,7 @@
'mobile-frontend-meta-data-issues-header' => 'Heading for overlay
listing all cleanup templates',
'mobile-frontend-meta-data-issues' => 'This should be several words and
should explain that an article has cleanup templates on it - meaning there is
room for improvement on the page. It appears in a button that when clicked
opens the overlay with heading
{{msg-mw|mobile-frontend-meta-data-issues-header}}',
'mobile-frontend-ajax-page-loading' => 'Text that accompanies an ajax
loader when you dynamically load an article via javascript',
+ 'mobile-frontend-image-ownership' => 'A statement saying the user
created the image where $1 is the username',
'mobile-frontend-page-saving' => 'Text shown whilst an article is being
saved',
'mobile-frontend-ajax-page-error' => 'Text that accompanies an ajax
loader when you dynamically load an article via javascript and it fails',
'mobile-frontend-nearby-title' => 'Title of Special:Nearby.
diff --git a/MobileFrontend.php b/MobileFrontend.php
index 573a344..b69578a 100644
--- a/MobileFrontend.php
+++ b/MobileFrontend.php
@@ -375,6 +375,7 @@
'mobile-frontend-watchlist-cta-button-login',
// mf-photo.js
+ 'mobile-frontend-image-ownership',
'mobile-frontend-photo-article-edit-comment',
'mobile-frontend-photo-article-donate-comment',
'mobile-frontend-photo-upload-error',
diff --git a/javascripts/modules/mf-photo.js b/javascripts/modules/mf-photo.js
index 1c4071e..cd5287f 100644
--- a/javascripts/modules/mf-photo.js
+++ b/javascripts/modules/mf-photo.js
@@ -213,7 +213,9 @@
setImageUrl: function( url ) {
this.imageUrl = url;
- this.$( '.loading' ).remove();
+ this.$( '.loading' ).removeClass( 'loading' ).text(
+ mw.msg( 'mobile-frontend-image-ownership',
mw.config.get( 'wgUserName' ) )
+ );
$( '<img>' ).attr( 'src', url ).prependTo( this.$(
'.photoPreview' ) );
}
} );
diff --git a/less/modules/mf-photo.less b/less/modules/mf-photo.less
index 648115e..c6e60bd 100644
--- a/less/modules/mf-photo.less
+++ b/less/modules/mf-photo.less
@@ -39,6 +39,9 @@
img {
height: @height;
+ float: left;
+ margin-bottom: 8px;
+ margin-right: 8px;
}
.loading {
diff --git a/stylesheets/modules/mf-photo.css b/stylesheets/modules/mf-photo.css
index 7ffeb7c..c1be8ab 100644
--- a/stylesheets/modules/mf-photo.css
+++ b/stylesheets/modules/mf-photo.css
@@ -33,6 +33,9 @@
}
.photoPreview img {
height: 90px;
+ float: left;
+ margin-bottom: 8px;
+ margin-right: 8px;
}
.photoPreview .loading {
background-position: 0 50%;
--
To view, visit https://gerrit.wikimedia.org/r/53876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8e4e52a3beab8700553b49e2683d1a6c624dc84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
