Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53879


Change subject: systemuser learned 'managehome' (default true)
......................................................................

systemuser learned 'managehome' (default true)

In some case we want to create a system user but absolutely do not want
puppet to mess with the homedir. That is the case for Jenkins.

systemuser thus learned the managehome parameter which default to true
to retains backcompatibility.

Change-Id: Icb8cd73ba7e3ad23b90715840c9092666340adcf
---
M manifests/generic-definitions.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/79/53879/1

diff --git a/manifests/generic-definitions.pp b/manifests/generic-definitions.pp
index 401dce0..74b3545 100644
--- a/manifests/generic-definitions.pp
+++ b/manifests/generic-definitions.pp
@@ -24,7 +24,7 @@
 }
 
 # Creates a system username with associated group, random uid/gid, and 
/bin/false as shell
-define systemuser($name, $home=undef, $shell="/bin/false", $groups=undef, 
$default_group=$name, $ensure=present) {
+define systemuser($name, $home=undef, $managehome=true, $shell="/bin/false", 
$groups=undef, $default_group=$name, $ensure=present) {
        # FIXME: deprecate $name parameter in favor of just using $title
 
        if $default_group == $name {
@@ -42,7 +42,7 @@
                        undef => "/var/lib/${name}",
                        default => $home
                },
-               managehome => true,
+               managehome => $managehome,
                shell => $shell,
                groups => $groups,
                system => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/53879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb8cd73ba7e3ad23b90715840c9092666340adcf
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to