Gehel has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369695 )
Change subject: redis - instance names should be strings in puppet 4
......................................................................
redis - instance names should be strings in puppet 4
Since the redis instances (`profile::redis::master::instances`) are used
as resource titles, they should be strings.
I found this error while checking maps for compatibility with puppet 4. OCG
is affected as well.
Change-Id: I8c65d0039d84bec38c639bfd3b25f5dbc66182a9
---
M hieradata/role/common/maps/master.yaml
M hieradata/role/common/maps/test/master.yaml
M hieradata/role/common/ocg.yaml
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/95/369695/1
diff --git a/hieradata/role/common/maps/master.yaml
b/hieradata/role/common/maps/master.yaml
index 324e8d8..05c0460 100644
--- a/hieradata/role/common/maps/master.yaml
+++ b/hieradata/role/common/maps/master.yaml
@@ -31,6 +31,6 @@
cassandra::metrics::blacklist:
- .*\.metrics\.Table\..*$
-profile::redis::master::instances: [6379]
+profile::redis::master::instances: ['6379']
profile::redis::master::settings:
bind: "0.0.0.0"
diff --git a/hieradata/role/common/maps/test/master.yaml
b/hieradata/role/common/maps/test/master.yaml
index 4cfa984..1726c86 100644
--- a/hieradata/role/common/maps/test/master.yaml
+++ b/hieradata/role/common/maps/test/master.yaml
@@ -28,6 +28,6 @@
cassandra::metrics::blacklist:
- .*\.metrics\.Table\..*$
-profile::redis::master::instances: [6379]
+profile::redis::master::instances: ['6379']
profile::redis::master::settings:
bind: "0.0.0.0"
diff --git a/hieradata/role/common/ocg.yaml b/hieradata/role/common/ocg.yaml
index 549021a..cd655966 100644
--- a/hieradata/role/common/ocg.yaml
+++ b/hieradata/role/common/ocg.yaml
@@ -10,7 +10,7 @@
debdeploy::grains:
debdeploy-ocg:
value: standard
-profile::redis::master::instances: [6379]
+profile::redis::master::instances: ['6379']
profile::redis::master::settings:
maxmemory: "2gb"
save: ""
--
To view, visit https://gerrit.wikimedia.org/r/369695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c65d0039d84bec38c639bfd3b25f5dbc66182a9
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Gehel <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
