JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53891
Change subject: Don't call closeNavigation() on touchend if no menu closed
......................................................................
Don't call closeNavigation() on touchend if no menu closed
Caused jumping to the top of the page on tapping content.
Change-Id: I597e4ac40b6431458d7cbde76030c825e3680ffe
---
M javascripts/common/mf-navigation.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/91/53891/1
diff --git a/javascripts/common/mf-navigation.js
b/javascripts/common/mf-navigation.js
index 7d3dc90..629d9fd 100644
--- a/javascripts/common/mf-navigation.js
+++ b/javascripts/common/mf-navigation.js
@@ -159,7 +159,11 @@
} );
// close navigation if content tapped
- $( '#mw-mf-page-center' ).on( 'touchend', closeNavigation );
+ $( '#mw-mf-page-center' ).on( 'touchend', function() {
+ if ( $( 'html' ).hasClass( 'navigationEnabled' ) ) {
+ closeNavigation();
+ }
+ } );
if( window.location.hash === '#mw-mf-page-left' ) {
openNavigation();
--
To view, visit https://gerrit.wikimedia.org/r/53891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I597e4ac40b6431458d7cbde76030c825e3680ffe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
