Trevor Parscal has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53900


Change subject: Remove unused .data()
......................................................................

Remove unused .data()

Just cleaning up the cruft

Change-Id: Ieffb108b234409a1122a984b45bdda688ce2014b
---
M modules/ve/ui/widgets/ve.ui.MenuItemWidget.js
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/00/53900/1

diff --git a/modules/ve/ui/widgets/ve.ui.MenuItemWidget.js 
b/modules/ve/ui/widgets/ve.ui.MenuItemWidget.js
index beeaf8f..21f67c5 100644
--- a/modules/ve/ui/widgets/ve.ui.MenuItemWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MenuItemWidget.js
@@ -50,10 +50,7 @@
        // Initialization
        this.setLabel( this.label );
        this.$label.addClass( 've-ui-menuItemWidget-label' );
-       this.$
-               .addClass( 've-ui-menuItemWidget' )
-               .append( this.$label )
-               .data( 'item', this );
+       this.$.addClass( 've-ui-menuItemWidget' ).append( this.$label );
        this.setHighlighted( config.highlighted );
        this.$.attr( 'rel', config.rel );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/53900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieffb108b234409a1122a984b45bdda688ce2014b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to