jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370174 )
Change subject: Sharpen DelegatingConstraintCheckerTest
......................................................................
Sharpen DelegatingConstraintCheckerTest
Check not only the number of check results, but also that they’re not
“todo” results – otherwise, the test will continue to pass unchanged
when we remove support for constraint templates, which we don’t want.
Change-Id: Ibf691c19f833b93976eb33e5878320db9c635a1f
---
M tests/phpunit/DelegatingConstraintCheckerTest.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/tests/phpunit/DelegatingConstraintCheckerTest.php
b/tests/phpunit/DelegatingConstraintCheckerTest.php
index c8d18f9..a8780b1 100644
--- a/tests/phpunit/DelegatingConstraintCheckerTest.php
+++ b/tests/phpunit/DelegatingConstraintCheckerTest.php
@@ -310,6 +310,9 @@
$entity = $this->lookup->getEntity( new ItemId( 'Q1' ) );
$result = $this->constraintChecker->checkAgainstConstraints(
$entity );
$this->assertEquals( 18, count( $result ), 'Every constraint
should be represented by one result' );
+ foreach ( $result as $checkResult ) {
+ $this->assertNotSame( 'todo',
$checkResult->getStatus(), 'Constraints should not be unimplemented' );
+ }
}
public function testCheckAgainstConstraintsWithoutEntity() {
--
To view, visit https://gerrit.wikimedia.org/r/370174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf691c19f833b93976eb33e5878320db9c635a1f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
