SrishtiSethi has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370283 )
Change subject: Check canHaveTalkPage() before calling getTalkPage()
......................................................................
Check canHaveTalkPage() before calling getTalkPage()
Bug: T172146
Change-Id: I0ebb7e80de56521bd54539bae7e2251eb62103c8
---
M includes/UserRolesMessage.php
1 file changed, 9 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram
refs/changes/83/370283/1
diff --git a/includes/UserRolesMessage.php b/includes/UserRolesMessage.php
index 2b0b2b6..660cb19 100644
--- a/includes/UserRolesMessage.php
+++ b/includes/UserRolesMessage.php
@@ -194,14 +194,18 @@
foreach ( $mainRoleCourses as $course ) {
$title = $course->getTitle();
-
- $msg = $this->out->msg(
+
+ $params = [
'ep-user-roles-message-course-link-for-list',
$title->getFullText(),
- $course->getName(),
- $title->getTalkPage()->getFullText()
- );
+ $course->getName()
+ ];
+ if($title->canHaveTalkPage()) {
+ $params[] =
$title->getTalkPage()->getFullText();
+ }
+
+ $msg = $this->out->msg( $params );
$courseLinks[] = $msg->plain();
}
--
To view, visit https://gerrit.wikimedia.org/r/370283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ebb7e80de56521bd54539bae7e2251eb62103c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: SrishtiSethi <srishaka...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
