jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369345 )

Change subject: build: bump grunt-jscs to 2.1.0
......................................................................


build: bump grunt-jscs to 2.1.0

Avoid a peer dependency incompatibility with grunt.

Ignore requireSpacesInsideBrackets for sake of simplicitly.

Inline ignore for requireVarDeclFirst to make it easier to follow code.

Explicitly set a 'return null' to please jsdoc or it would not let us
document the @return {NULL}.

Change-Id: If81ad41eaf4b3ea9405f15b8a2d20c4b83ba5a56
---
M .jscsrc
M modules/ext.LanguageToolDialog.js
M package.json
3 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.jscsrc b/.jscsrc
index 9d22e3f..ee570d1 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -1,3 +1,5 @@
 {
-       "preset": "wikimedia"
+       "preset": "wikimedia",
+       "requireSpacesInsideBrackets": false,
+       "verbose": true
 }
diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index 4debc15..c22760f 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -97,6 +97,7 @@
                label: ve.msg( 'visualeditor-find-and-replace-replace-button' )
        } );
 
+       // jscs:disable requireVarDeclFirst
        var optionsGroup = new OO.ui.ButtonGroupWidget( {
                        classes: [ 've-ui-findAndReplaceDialog-cell' ],
                        items: [
@@ -493,7 +494,7 @@
        } ).done( function ( responseXML ) {
                self.openDialog.apply( self, [ responseXML, mapper ] );
        } );
-       return;
+       return null;
 };
 
 mw.LanguageToolDialog.prototype.openDialog = function ( responseXML, mapper ) {
diff --git a/package.json b/package.json
index ff8bbd1..0481945 100644
--- a/package.json
+++ b/package.json
@@ -8,7 +8,7 @@
     "grunt": "1.0.1",
     "grunt-banana-checker": "0.4.0",
     "grunt-contrib-jshint": "0.11.3",
-    "grunt-jscs": "1.8.0",
+    "grunt-jscs": "2.1.0",
     "grunt-jsonlint": "1.1.0"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/369345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If81ad41eaf4b3ea9405f15b8a2d20c4b83ba5a56
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to