Thiemo Mättig (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370323 )

Change subject: Make QUnit test more compatible by using expect()
......................................................................

Make QUnit test more compatible by using expect()

Change-Id: I3abd06180d04aa681cc82a06778ce77421683b32
---
M 
tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/23/370323/1

diff --git 
a/tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
 
b/tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
index 5a60398..d429026 100644
--- 
a/tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
+++ 
b/tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
@@ -1,6 +1,7 @@
 ( function ( mw, $ ) {
        QUnit.module( 'ext.WikidataPageBanner.positionBanner', 
QUnit.newMwEnvironment() );
-       QUnit.test( 'testFocus', 10, function ( assert ) {
+       QUnit.test( 'testFocus', function ( assert ) {
+               assert.expect( 10 );
                this.$wpbBannerImageContainer = $( '<div/>', {
                        width: 600,
                        height: 300

-- 
To view, visit https://gerrit.wikimedia.org/r/370323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3abd06180d04aa681cc82a06778ce77421683b32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to