Foxy brown has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370366 )
Change subject: Added a text placeholder to the DateTimeInputWidget config option ...................................................................... Added a text placeholder to the DateTimeInputWidget config option Change-Id: Ic475ae9e80e353b7f042ed36c77fd47703301de4 --- M resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js M resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/66/370366/1 diff --git a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js index 9233eef..901c619 100644 --- a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js +++ b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js @@ -36,6 +36,7 @@ * @cfg {boolean} [required=false] Whether a value is required. * @cfg {boolean} [clearable=true] Whether to provide for blanking the value. * @cfg {Date|null} [value=null] Default value for the widget + * @cfg {string|null} [placeholder=null] Default value for the widget * @cfg {Date|string|null} [min=null] Minimum allowed date * @cfg {Date|string|null} [max=null] Maximum allowed date */ @@ -45,6 +46,7 @@ type: 'datetime', clearable: true, required: false, + placeholder: null, min: null, max: null, formatter: {}, @@ -154,6 +156,9 @@ this.$fields.addClass( 'mw-widgets-datetime-dateTimeInputWidget-fields' ); this.setupFields(); + if ( config.placeholder ) { + this.$fields.attr( 'data-placeholder', config.placeholder ); + } this.$handle .addClass( 'mw-widgets-datetime-dateTimeInputWidget-handle' ) diff --git a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less index f205da3..2496713 100644 --- a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less +++ b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less @@ -18,6 +18,17 @@ display: table-cell; white-space: pre; } + &[data-placeholder]:not(:focus):before { + content: attr( data-placeholder ); + float: left; + margin-left: 2px; + } + } + + &-empty { + .mw-widgets-datetime-dateTimeInputWidget-field { + opacity: 0; + } } &-handle { -- To view, visit https://gerrit.wikimedia.org/r/370366 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic475ae9e80e353b7f042ed36c77fd47703301de4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Foxy brown <elaa...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits