jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367656 )

Change subject: Use HTML::hidden to create input fields
......................................................................


Use HTML::hidden to create input fields

Also add line break to comment added some patch before.

Change-Id: I9bd66b8444c069b4055fc5c3396256b688b78561
---
M includes/EditPage.php
1 file changed, 8 insertions(+), 11 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, but someone else must approve
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/EditPage.php b/includes/EditPage.php
index 229a36a..e5fb4c5 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -3220,16 +3220,13 @@
 
        protected function showFormBeforeText() {
                global $wgOut;
-               $section = htmlspecialchars( $this->section );
-               $wgOut->addHTML( <<<HTML
-<input type='hidden' value="{$section}" name="wpSection"/>
-<input type='hidden' value="{$this->starttime}" name="wpStarttime" />
-<input type='hidden' value="{$this->edittime}" name="wpEdittime" />
-<input type='hidden' value="{$this->editRevId}" name="editRevId" />
-<input type='hidden' value="{$this->scrolltop}" name="wpScrolltop" 
id="wpScrolltop" />
 
-HTML
-               );
+               $wgOut->addHTML( Html::hidden( 'wpSection', htmlspecialchars( 
$this->section ) ) );
+               $wgOut->addHTML( Html::hidden( 'wpStarttime', $this->starttime 
) );
+               $wgOut->addHTML( Html::hidden( 'wpEdittime', $this->edittime ) 
);
+               $wgOut->addHTML( Html::hidden( 'editRevId', $this->editRevId ) 
);
+               $wgOut->addHTML( Html::hidden( 'wpScrolltop', $this->scrolltop 
) );
+
                if ( !$this->checkUnicodeCompliantBrowser() ) {
                        $wgOut->addHTML( Html::hidden( 'safemode', '1' ) );
                }
@@ -3493,8 +3490,8 @@
        }
 
        /**
-        * Inserts optional text shown below edit and upload forms. Can be used 
to offer special characters not present on
-        * most keyboards for copying/pasting.
+        * Inserts optional text shown below edit and upload forms. Can be used 
to offer special
+        * characters not present on most keyboards for copying/pasting.
         */
        protected function showEditTools() {
                global $wgOut;

-- 
To view, visit https://gerrit.wikimedia.org/r/367656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9bd66b8444c069b4055fc5c3396256b688b78561
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Tpt <thoma...@hotmail.fr>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to