GeoffreyT2000 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370479 )
Change subject: Make Special:NewPages show "originally created as" correctly
......................................................................
Make Special:NewPages show "originally created as" correctly
$ret should not be generated until after $oldTitleText is generated. Then
"originally created as" will be correctly shown, as expected.
Bug: T171138
Change-Id: Ibcf9f36a46cfc4beb0aaa424e35a334ed73a1c98
---
M includes/specials/SpecialNewpages.php
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/79/370479/1
diff --git a/includes/specials/SpecialNewpages.php
b/includes/specials/SpecialNewpages.php
index 83482f6..f644189 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -382,12 +382,6 @@
# Display the old title if the namespace/title has been changed
$oldTitleText = '';
$oldTitle = Title::makeTitle( $result->rc_namespace,
$result->rc_title );
- $ret = "{$time} {$dm}{$plink} {$hist} {$dm}{$length}
{$dm}{$ulink} {$comment} "
- . "{$tagDisplay} {$oldTitleText}";
-
- // Let extensions add data
- Hooks::run( 'NewPagesLineEnding', [ $this, &$ret, $result,
&$classes, &$attribs ] );
- $attribs = wfArrayFilterByKey( $attribs, [ Sanitizer::class,
'isReservedDataAttribute' ] );
if ( count( $classes ) ) {
$attribs['class'] = implode( ' ', $classes );
@@ -402,6 +396,13 @@
);
}
+ $ret = "{$time} {$dm}{$plink} {$hist} {$dm}{$length}
{$dm}{$ulink} {$comment} "
+ . "{$tagDisplay} {$oldTitleText}";
+
+ // Let extensions add data
+ Hooks::run( 'NewPagesLineEnding', [ $this, &$ret, $result,
&$classes, &$attribs ] );
+ $attribs = wfArrayFilterByKey( $attribs, [ Sanitizer::class,
'isReservedDataAttribute' ] );
+
return Html::rawElement( 'li', $attribs, $ret ) . "\n";
}
--
To view, visit https://gerrit.wikimedia.org/r/370479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcf9f36a46cfc4beb0aaa424e35a334ed73a1c98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: GeoffreyT2000 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
