Jcasariego has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370490 )
Change subject: Show ellipsis to indicate truncation in the reading list
list-item
......................................................................
Show ellipsis to indicate truncation in the reading list list-item
This task add ellipsis for reading lists with description text that exceeds the
2-lines.
Bug: T164926
Change-Id: I5bdf748820b4db15d4a7dc07192a598dae99389f
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
M app/src/main/res/values/strings_no_translate.xml
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/90/370490/1
diff --git
a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
index 0488db9..d0ac931 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
@@ -83,6 +83,11 @@
statisticalDescriptionView.setText(text);
updateDetails();
+
+ if (description != Description.DETAIL){
+ showEllipsis();
+ }
+
if (imageContainer.getVisibility() == VISIBLE) {
getThumbnails();
}
@@ -255,4 +260,18 @@
return false;
}
}
+
+ private void showEllipsis(){
+ descriptionView.post(new Runnable() {
+ @Override
+ public void run() {
+ if (descriptionView.getLineCount() > 2) {
+ final int threeSpaces = 3;
+ int lineEndIndex =
descriptionView.getLayout().getLineEnd(1);
+ String text = descriptionView.getText().subSequence(0,
lineEndIndex - threeSpaces) + getString(R.string.ellipsis);
+ descriptionView.setText(text);
+ }
+ }
+ });
+ }
}
diff --git a/app/src/main/res/values/strings_no_translate.xml
b/app/src/main/res/values/strings_no_translate.xml
index 35a169a..a0753f1 100644
--- a/app/src/main/res/values/strings_no_translate.xml
+++ b/app/src/main/res/values/strings_no_translate.xml
@@ -112,4 +112,8 @@
<string name="storage_size_format">%.2f</string>
+ <!-- Ellipsis -->
+ <string name="ellipsis">\u2026</string>
+
+
</resources>
--
To view, visit https://gerrit.wikimedia.org/r/370490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bdf748820b4db15d4a7dc07192a598dae99389f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
