jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370488 )
Change subject: Fix navigating to file page from gallery images.
......................................................................
Fix navigating to file page from gallery images.
The call to startActivityForResult() must be made from the context of the
activity that will be receiving the onActivityResult() event.
Bug: T170755
Change-Id: I8fce78c094ef67d6ee471664e81873a114407a08
---
M app/src/main/java/org/wikipedia/page/PageFragment.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java
b/app/src/main/java/org/wikipedia/page/PageFragment.java
index d6f3d0c..eb17502 100755
--- a/app/src/main/java/org/wikipedia/page/PageFragment.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragment.java
@@ -1131,7 +1131,7 @@
if (href.startsWith("/wiki/")) {
String filename =
UriUtil.removeInternalLinkPrefix(href);
WikiSite wiki = model.getTitle().getWikiSite();
-
startActivityForResult(GalleryActivity.newIntent(getContext(),
+
getActivity().startActivityForResult(GalleryActivity.newIntent(getActivity(),
model.getTitleOriginal(), filename, wiki,
GalleryFunnel.SOURCE_NON_LEAD_IMAGE),
Constants.ACTIVITY_REQUEST_GALLERY);
@@ -1149,7 +1149,7 @@
String href = decodeURL(messagePayload.getString("href"));
String filename =
StringUtil.removeUnderscores(UriUtil.removeInternalLinkPrefix(href));
WikiSite wiki = model.getTitle().getWikiSite();
-
startActivityForResult(GalleryActivity.newIntent(getContext(),
+
getActivity().startActivityForResult(GalleryActivity.newIntent(getActivity(),
model.getTitleOriginal(), filename, wiki,
GalleryFunnel.SOURCE_NON_LEAD_IMAGE),
Constants.ACTIVITY_REQUEST_GALLERY);
--
To view, visit https://gerrit.wikimedia.org/r/370488
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fce78c094ef67d6ee471664e81873a114407a08
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
