Elukey has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370637 )
Change subject: role::cache::kafka::*: force kafka protocol to 0.9.0.1 ...................................................................... role::cache::kafka::*: force kafka protocol to 0.9.0.1 This change implements a workaround for kafka protocol versions 0.9.0.[0,1] to limit the effects of unwanted timeouts for producers while negotiating the protocol version with the broker. These options will set the corresponding librdkafka tunables as described in: https://github.com/edenhill/librdkafka/wiki/Broker-version-compatibility This is probably not the main issue of T172681 but all the bug reports and upstream suggestions leads to it. Related change: https://gerrit.wikimedia.org/r/#/c/370631/ Bug: T172681 Change-Id: Id8f2ceb639fd4abffee198e89acdf7708dfce9bd --- M modules/role/manifests/cache/kafka/eventlogging.pp M modules/role/manifests/cache/kafka/statsv.pp M modules/role/manifests/cache/kafka/webrequest.pp M modules/varnishkafka 4 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/37/370637/1 diff --git a/modules/role/manifests/cache/kafka/eventlogging.pp b/modules/role/manifests/cache/kafka/eventlogging.pp index d4a213b..47bf36d 100644 --- a/modules/role/manifests/cache/kafka/eventlogging.pp +++ b/modules/role/manifests/cache/kafka/eventlogging.pp @@ -39,6 +39,7 @@ varnish_opts => $varnish_opts, topic_request_required_acks => '1', conf_template => $conf_template, + force_protocol_version => '0.9.0.1', } include ::standard diff --git a/modules/role/manifests/cache/kafka/statsv.pp b/modules/role/manifests/cache/kafka/statsv.pp index 5b1de78..800eb74 100644 --- a/modules/role/manifests/cache/kafka/statsv.pp +++ b/modules/role/manifests/cache/kafka/statsv.pp @@ -39,6 +39,7 @@ # -1 means all brokers in the ISR must ACK this request. topic_request_required_acks => '-1', conf_template => $conf_template, + force_protocol_version => '0.9.0.1', } include ::standard diff --git a/modules/role/manifests/cache/kafka/webrequest.pp b/modules/role/manifests/cache/kafka/webrequest.pp index a446d7b..b12d7c0 100644 --- a/modules/role/manifests/cache/kafka/webrequest.pp +++ b/modules/role/manifests/cache/kafka/webrequest.pp @@ -113,6 +113,7 @@ # stats will be fresh when polled from gmetad. log_statistics_interval => 15, conf_template => $conf_template, + force_protocol_version => '0.9.0.1', } include ::standard diff --git a/modules/varnishkafka b/modules/varnishkafka index 8822159..a3651c8 160000 --- a/modules/varnishkafka +++ b/modules/varnishkafka @@ -1 +1 @@ -Subproject commit 8822159469238c14aedfaf01d15e27658199a157 +Subproject commit a3651c852cfc00d6c3a81a0608b3328b5fb6159c -- To view, visit https://gerrit.wikimedia.org/r/370637 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8f2ceb639fd4abffee198e89acdf7708dfce9bd Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Elukey <ltosc...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
