jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370635 )

Change subject: Hygiene: omit slash in jQuery node creation
......................................................................


Hygiene: omit slash in jQuery node creation

https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions#jQuery

Change-Id: I092576ebc5eda3558bb22410afe923974e10e249
---
M resources/mobile.editor.overlay/EditorOverlay.js
M resources/mobile.startup/Skin.js
M tests/qunit/mobile.startup/test_Page.js
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pmiazga: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mobile.editor.overlay/EditorOverlay.js 
b/resources/mobile.editor.overlay/EditorOverlay.js
index 3713e5f..1114fd1 100644
--- a/resources/mobile.editor.overlay/EditorOverlay.js
+++ b/resources/mobile.editor.overlay/EditorOverlay.js
@@ -265,7 +265,7 @@
                        }
                        this.gateway.getPreview( params ).done( function ( 
parsedText, parsedSectionLine ) {
                                // On desktop edit summaries strip tags. Mimic 
this behavior on mobile devices
-                               self.sectionLine = $( '<div/>' ).html( 
parsedSectionLine ).text();
+                               self.sectionLine = $( '<div>' ).html( 
parsedSectionLine ).text();
                                new Section( {
                                        el: self.$preview,
                                        text: parsedText
diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js
index ee5cb87..600c774 100644
--- a/resources/mobile.startup/Skin.js
+++ b/resources/mobile.startup/Skin.js
@@ -223,7 +223,7 @@
                                width = $placeholder.attr( 'data-width' ),
                                height = $placeholder.attr( 'data-height' ),
                                // Image will start downloading
-                               $downloadingImage = $( '<img/>' );
+                               $downloadingImage = $( '<img>' );
 
                        // When the image has loaded
                        $downloadingImage.on( 'load', function () {
diff --git a/tests/qunit/mobile.startup/test_Page.js 
b/tests/qunit/mobile.startup/test_Page.js
index 58f31ed..a2b1c40 100644
--- a/tests/qunit/mobile.startup/test_Page.js
+++ b/tests/qunit/mobile.startup/test_Page.js
@@ -23,7 +23,7 @@
                        el: $( '<div><a 
href="/wiki/File:Cyanolimnas_cerverai_by_Allan_Brooks_cropped.jpg" class="image 
view-border-box"><img alt="Cyanolimnas cerverai by Allan Brooks cropped.jpg" 
src="//upload.wikimedia.org/wikipedia/commons/thumb/0/0d/Cyanolimnas_cerverai_by_Allan_Brooks_cropped.jpg/300px-Cyanolimnas_cerverai_by_Allan_Brooks_cropped.jpg"
 width="300" height="303" data-file-width="454" 
data-file-height="459"></a></div>' )
                } );
                textPage = new Page( {
-                       el: $( '<div />' )
+                       el: $( '<div>' )
                } );
                pLegacyUrls = new Page( {
                        el: $( '<div><a 
href="/wikpa/index.php?title=File:Cyanolimnas_cerverai_by_Allan_Brooks_cropped.jpg"
 class="image view-border-box"><img alt="Cyanolimnas cerverai by Allan Brooks 
cropped.jpg" 
src="//upload.wikimedia.org/wikipedia/commons/thumb/0/0d/Cyanolimnas_cerverai_by_Allan_Brooks_cropped.jpg/300px-Cyanolimnas_cerverai_by_Allan_Brooks_cropped.jpg"
 width="300" height="303" data-file-width="454" 
data-file-height="459"></a></div>' )

-- 
To view, visit https://gerrit.wikimedia.org/r/370635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I092576ebc5eda3558bb22410afe923974e10e249
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to