Elukey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370659 )

Change subject: role::cache::kafka::webrequest: force Kafka protocol to 0.9.0.1
......................................................................

role::cache::kafka::webrequest: force Kafka protocol to 0.9.0.1

Also adds missing documentation in statsv/eventlogging roles.

Bug: T172681
Change-Id: Id50fc9d0bbd5c161fb2fec0fc77fd6bf23362e7f
---
M modules/role/manifests/cache/kafka/eventlogging.pp
M modules/role/manifests/cache/kafka/statsv.pp
M modules/role/manifests/cache/kafka/webrequest.pp
3 files changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/59/370659/1

diff --git a/modules/role/manifests/cache/kafka/eventlogging.pp 
b/modules/role/manifests/cache/kafka/eventlogging.pp
index fbd2a00..937df62 100644
--- a/modules/role/manifests/cache/kafka/eventlogging.pp
+++ b/modules/role/manifests/cache/kafka/eventlogging.pp
@@ -13,6 +13,9 @@
 # [*varnish_svc_name*]
 #   The name of the init unit for the above.
 #   Default 'varnish-frontend'
+# [*kafka_protocol_version*]
+#   Kafka API version to use, needed for brokers < 0.10
+#   https://issues.apache.org/jira/browse/KAFKA-3547
 #
 class role::cache::kafka::eventlogging(
     $varnish_name           = 'frontend',
diff --git a/modules/role/manifests/cache/kafka/statsv.pp 
b/modules/role/manifests/cache/kafka/statsv.pp
index 6843229..5552c60 100644
--- a/modules/role/manifests/cache/kafka/statsv.pp
+++ b/modules/role/manifests/cache/kafka/statsv.pp
@@ -13,6 +13,9 @@
 # [*varnish_svc_name*]
 #   The name of the init unit for the above.
 #   Default 'varnish-frontend'
+# [*kafka_protocol_version*]
+#   Kafka API version to use, needed for brokers < 0.10
+#   https://issues.apache.org/jira/browse/KAFKA-3547
 #
 class role::cache::kafka::statsv(
     $varnish_name           = 'frontend',
diff --git a/modules/role/manifests/cache/kafka/webrequest.pp 
b/modules/role/manifests/cache/kafka/webrequest.pp
index a446d7b..7131fa8 100644
--- a/modules/role/manifests/cache/kafka/webrequest.pp
+++ b/modules/role/manifests/cache/kafka/webrequest.pp
@@ -13,11 +13,15 @@
 # [*varnish_svc_name*]
 #   The name of the init unit for the above.
 #   Default 'varnish-frontend'
+# [*kafka_protocol_version*]
+#   Kafka API version to use, needed for brokers < 0.10
+#   https://issues.apache.org/jira/browse/KAFKA-3547
 #
 class role::cache::kafka::webrequest(
     $topic,
-    $varnish_name = 'frontend',
-    $varnish_svc_name = 'varnish-frontend'
+    $varnish_name           = 'frontend',
+    $varnish_svc_name       = 'varnish-frontend',
+    $kafka_protocol_version = '0.9.0.1',
 ) inherits role::cache::kafka
 {
     # Background task: T136314

-- 
To view, visit https://gerrit.wikimedia.org/r/370659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id50fc9d0bbd5c161fb2fec0fc77fd6bf23362e7f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <ltosc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to