jenkins-bot has submitted this change and it was merged.

Change subject: (Bug 45959) [TUX] Workflow state selector hard to hide
......................................................................


(Bug 45959) [TUX] Workflow state selector hard to hide

Bug: 45959
Change-Id: I8dca0dd859b700eddd1b68e27001aa08188ea82c
---
M resources/js/ext.translate.special.translate.js
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.translate.special.translate.js 
b/resources/js/ext.translate.special.translate.js
index dd1259a..6b37ec0 100644
--- a/resources/js/ext.translate.special.translate.js
+++ b/resources/js/ext.translate.special.translate.js
@@ -372,11 +372,15 @@
                } );
 
                // Workflow state selector
+
+               // Toggling menu visibility
                $translateContainer.find( '.tux-workflow-status' )
-                       .on( 'click', function () {
+                       .on( 'click', function ( e ) {
                                $( this ).next( 'ul' ).toggleClass( 'hide' );
+                               e.preventDefault();
                        } );
 
+               // Handling state changes
                $translateContainer.find( '.tux-workflow-status-selector li' )
                        .on( 'click', function () {
                                var state, stateText, $selector,
@@ -399,6 +403,13 @@
                                } );
                        } );
 
+               // Hide the workflow selector when clicking outside of it
+               $( 'html' ).on( 'click', function ( e ) {
+                       if ( !e.isDefaultPrevented() ) {
+                               $( 'ul.tux-workflow-status-selector' 
).addClass( 'hide' );
+                       }
+               } );
+
                // Message filter click handler
                $translateContainer.find( '.row.tux-message-selector > li' 
).on( 'click', function () {
                        var newFilter,

-- 
To view, visit https://gerrit.wikimedia.org/r/53745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8dca0dd859b700eddd1b68e27001aa08188ea82c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to