Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370824 )

Change subject: Improve some parameter docs
......................................................................

Improve some parameter docs

Change-Id: I20e3e281bd5b17133b1d8b5fbdc10d7127c930d0
---
M backend/FRDependencyUpdate.php
M backend/FRPageConfig.php
M backend/FRUserActivity.php
M backend/FRUserCounters.php
M backend/FlaggedRevision.php
M backend/FlaggedRevs.class.php
M backend/FlaggedRevs.hooks.php
M backend/FlaggedRevsLog.php
M business/RevisionReviewForm.php
M frontend/FlaggablePageView.php
M frontend/FlaggedRevsUI.hooks.php
M frontend/FlaggedRevsUI.setup.php
M frontend/FlaggedRevsXML.php
M frontend/RevisionReviewFormUI.php
M frontend/specialpages/reports/ProblemChanges_body.php
M phpcs.xml
16 files changed, 99 insertions(+), 83 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/24/370824/1

diff --git a/backend/FRDependencyUpdate.php b/backend/FRDependencyUpdate.php
index f38c7b6..fb658ed 100644
--- a/backend/FRDependencyUpdate.php
+++ b/backend/FRDependencyUpdate.php
@@ -24,7 +24,7 @@
        }
 
        /**
-        * @param integer $mode 
FRDependencyUpdate::IMMEDIATE/FRDependencyUpdate::DEFERRED
+        * @param int $mode 
FRDependencyUpdate::IMMEDIATE/FRDependencyUpdate::DEFERRED
         */
        public function doUpdate( $mode = self::IMMEDIATE ) {
                $deps = [];
diff --git a/backend/FRPageConfig.php b/backend/FRPageConfig.php
index 6ec5a26..1d39f47 100644
--- a/backend/FRPageConfig.php
+++ b/backend/FRPageConfig.php
@@ -5,8 +5,8 @@
 class FRPageConfig {
        /**
         * Get visibility settings/restrictions for a page
-        * @param Title $title, page title
-        * @param int $flags, FR_MASTER
+        * @param Title $title page title
+        * @param int $flags FR_MASTER
         * @return array (associative) (select,override,autoreview,expiry)
         */
        public static function getStabilitySettings( Title $title, $flags = 0 ) 
{
@@ -29,6 +29,7 @@
 
        /**
         * Get page configuration settings from a DB row
+        * @param stdClass $row
         */
        public static function getVisibilitySettingsFromRow( $row ) {
                if ( $row ) {
diff --git a/backend/FRUserActivity.php b/backend/FRUserActivity.php
index 07c0439..c0c2043 100644
--- a/backend/FRUserActivity.php
+++ b/backend/FRUserActivity.php
@@ -176,7 +176,7 @@
        /**
         * @param string $key
         * @param User $user
-        * @param integer $ttlSec
+        * @param int $ttlSec
         * @return bool
         */
        protected static function incUserReviewingItem( $key, User $user, 
$ttlSec ) {
@@ -207,7 +207,7 @@
        /**
         * @param string $key
         * @param User $user
-        * @param integer $ttlSec
+        * @param int $ttlSec
         * @return bool
         */
        protected static function decUserReviewingItem( $key, User $user, 
$ttlSec ) {
diff --git a/backend/FRUserCounters.php b/backend/FRUserCounters.php
index 00d98ee..cdba35a 100644
--- a/backend/FRUserCounters.php
+++ b/backend/FRUserCounters.php
@@ -37,7 +37,7 @@
 
        /**
         * Initializes unset param fields to their starting values
-        * @param array $p
+        * @param array &$p
         */
        protected static function setUnitializedFields( array &$p ) {
                if ( !isset( $p['uniqueContentPages'] ) ) {
@@ -185,7 +185,7 @@
 
        /**
         * Update users params array for a user on edit
-        * @param array $p user params
+        * @param array &$p user params
         * @param Page $article the article just edited
         * @param string $summary edit summary
         * @return bool anything changed
diff --git a/backend/FlaggedRevision.php b/backend/FlaggedRevision.php
index 70699fd..0ab0c9e 100644
--- a/backend/FlaggedRevision.php
+++ b/backend/FlaggedRevision.php
@@ -145,7 +145,7 @@
         * Get a FlaggedRevision of the stable version of a title.
         * Note: will return NULL if the revision is deleted, though this
         * should never happen as fp_stable is updated as revs are deleted.
-        * @param Title $title, page title
+        * @param Title $title page title
         * @param int $flags (FR_MASTER, FR_FOR_UPDATE)
         * @return FlaggedRevision|null (null on failure)
         */
@@ -235,7 +235,7 @@
 
        /**
         * Get the ID of the stable version of a title.
-        * @param Title $title, page title
+        * @param Title $title page title
         * @param int $flags (FR_MASTER, FR_FOR_UPDATE)
         * @return int (0 on failure)
         */
@@ -247,9 +247,9 @@
        /**
         * Get a FlaggedRevision of the stable version of a title.
         * Skips tracking tables to figure out new stable version.
-        * @param Title $title, page title
+        * @param Title $title page title
         * @param int $flags (FR_MASTER, FR_FOR_UPDATE)
-        * @param array $config, optional page config (use to skip queries)
+        * @param array $config optional page config (use to skip queries)
         * @param string $precedence (latest,quality,pristine)
         * @return FlaggedRevision|null (null on failure)
         */
diff --git a/backend/FlaggedRevs.class.php b/backend/FlaggedRevs.class.php
index 11bbb6e..46fa460 100644
--- a/backend/FlaggedRevs.class.php
+++ b/backend/FlaggedRevs.class.php
@@ -483,8 +483,8 @@
         * Returns true if a user can set $flags for a revision via review.
         * Requires the same for $oldflags if given.
         * @param User $user
-        * @param array $flags, suggested flags
-        * @param array $oldflags, pre-existing flags
+        * @param array $flags suggested flags
+        * @param array $oldflags pre-existing flags
         * @return bool
         */
        public static function userCanSetFlags( $user, array $flags, $oldflags 
= [] ) {
@@ -615,9 +615,9 @@
        /**
         * Update the page tables with a new stable version.
         * @param WikiPage|Title $page
-        * @param FlaggedRevision|null $sv, the new stable version (optional)
-        * @param FlaggedRevision|null $oldSv, the old stable version (optional)
-        * @param Object editInfo Article edit info about the current revision 
(optional)
+        * @param FlaggedRevision|null $sv the new stable version (optional)
+        * @param FlaggedRevision|null $oldSv the old stable version (optional)
+        * @param Object $editInfo Article edit info about the current revision 
(optional)
         * @return bool stable version text/file changed and FR_INCLUDES_STABLE
         * @throws Exception
         */
@@ -693,7 +693,7 @@
        /**
         * @param Page $article
         * @param ParserOutput $stableOut
-        * @param integer $mode 
FRDependencyUpdate::DEFERRED/FRDependencyUpdate::IMMEDIATE
+        * @param int $mode 
FRDependencyUpdate::DEFERRED/FRDependencyUpdate::IMMEDIATE
         * Updates the stable-only cache dependency table
         */
        public static function updateStableOnlyDeps( Page $article, 
ParserOutput $stableOut, $mode ) {
diff --git a/backend/FlaggedRevs.hooks.php b/backend/FlaggedRevs.hooks.php
index 6c8c793..b7b7114 100644
--- a/backend/FlaggedRevs.hooks.php
+++ b/backend/FlaggedRevs.hooks.php
@@ -762,9 +762,9 @@
 
        /**
         * Check if a user has enough implicitly reviewed edits (before stable 
version)
-        * @param $user User
-        * @param $editsReq int
-        * @param $seconds int
+        * @param User $user
+        * @param int $editsReq
+        * @param int $seconds
         * @return bool
         */
        protected static function reviewedEditsCheck( User $user, $editsReq, 
$seconds = 0 ) {
@@ -1076,8 +1076,8 @@
 
        /**
         * Handler for EchoGetDefaultNotifiedUsers hook.
-        * @param $event EchoEvent to get implicitly subscribed users for
-        * @param &$users Array to append implicitly subscribed users to.
+        * @param EchoEvent $event EchoEvent to get implicitly subscribed users 
for
+        * @param array &$users Array to append implicitly subscribed users to.
         * @return bool true in all cases
         */
        public static function onEchoGetDefaultNotifiedUsers( $event, &$users ) 
{
@@ -1091,7 +1091,7 @@
        }
 
        /**
-        * @param array $updateFields
+        * @param array &$updateFields
         * @return bool
         */
        public static function onUserMergeAccountFields( array &$updateFields ) 
{
diff --git a/backend/FlaggedRevsLog.php b/backend/FlaggedRevsLog.php
index 3cb00a5..7cbd516 100644
--- a/backend/FlaggedRevsLog.php
+++ b/backend/FlaggedRevsLog.php
@@ -7,9 +7,9 @@
         * @param array $dims
         * @param array $oldDims
         * @param string $comment
-        * @param int $revId, revision ID
-        * @param int $stableId, prior stable revision ID
-        * @param bool $approve, approved? (otherwise unapproved)
+        * @param int $revId revision ID
+        * @param int $stableId prior stable revision ID
+        * @param bool $approve approved? (otherwise unapproved)
         * @param bool $auto
         * @param User $user performing the action
         */
diff --git a/business/RevisionReviewForm.php b/business/RevisionReviewForm.php
index 43ef44a..f50a537 100644
--- a/business/RevisionReviewForm.php
+++ b/business/RevisionReviewForm.php
@@ -528,7 +528,7 @@
         * @param string $tmpP
         * @param string $imgP
         * @param string $imgV
-        * @param integer $rid rev ID
+        * @param int $rid rev ID
         * @param string $sessKey Session key
         * @return string
         */
@@ -545,9 +545,9 @@
         *
         * RecentChange should only be passed in when an RC item is saved.
         *
-        * @param $rev Revision|RecentChange
-        * @param $patrol string "patrol" or "unpatrol"
-        * @param $srev FlaggedRevision|null The new stable version
+        * @param Revision|RecentChange $rev
+        * @param string $patrol "patrol" or "unpatrol"
+        * @param FlaggedRevision|null $srev The new stable version
         * @return void
         */
        public static function updateRecentChanges( $rev, $patrol, $srev ) {
@@ -603,10 +603,10 @@
 
        /**
         * Get template and image parameters from parser output to use on forms.
-        * @param $templateIDs Array (from 
ParserOutput/OutputPage->mTemplateIds)
-        * @param $imageSHA1Keys Array (from 
ParserOutput/OutputPage->mImageTimeKeys)
-        * @param $fileVersion Array|null version of file for File: pages 
(time,sha1)
-        * @return [ templateParams, imageParams, fileVersion ]
+        * @param array $templateIDs Array (from 
ParserOutput/OutputPage->mTemplateIds)
+        * @param array $imageSHA1Keys Array (from 
ParserOutput/OutputPage->mImageTimeKeys)
+        * @param array|null $fileVersion Array|null version of file for File: 
pages (time,sha1)
+        * @return array [ templateParams, imageParams, fileVersion ]
         */
        public static function getIncludeParams(
                array $templateIDs, array $imageSHA1Keys, $fileVersion
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 8ee8bdf..c0fc93d 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -162,7 +162,7 @@
 
        /**
         * Should this user see the draft revision of pages by default?
-        * @param $user User
+        * @param User $user
         * @return bool
         */
        protected function userViewsDraftByDefault( $user ) {
@@ -186,7 +186,7 @@
 
        /**
         * Is this a view page action (including diffs)?
-        * @param $request WebRequest
+        * @param WebRequest $request
         * @return bool
         */
        protected function isPageViewOrDiff( WebRequest $request ) {
@@ -199,7 +199,7 @@
 
        /**
         * Is this a view page action (not including diffs)?
-        * @param $request WebRequest
+        * @param WebRequest $request
         * @return bool
         */
        protected function isPageView( WebRequest $request ) {
@@ -209,7 +209,7 @@
 
        /**
         * Is this a web request to just *view* the *default* version of a page?
-        * @param $request WebRequest
+        * @param WebRequest $request
         * @return bool
         */
        protected function isDefaultPageView( WebRequest $request ) {
@@ -227,7 +227,7 @@
 
        /**
         * Is this a view page action?
-        * @param $action string from MediaWiki::getAction()
+        * @param string $action string from MediaWiki::getAction()
         * @return bool
         */
        protected static function isViewAction( $action ) {
@@ -236,6 +236,7 @@
 
        /**
         * Output review notice
+        * @return true
         */
        public function displayTag() {
                $this->load();
@@ -249,6 +250,7 @@
        /**
         * Add a stable link when viewing old versions of an article that
         * have been reviewed. (e.g. for &oldid=x urls)
+        * @return true
         */
        public function addStableLink() {
                $request = $this->getRequest();
@@ -298,6 +300,9 @@
         * Replaces a page with the last stable version if possible
         * Adds stable version status/info tags and notes
         * Adds a quick review form on the bottom if needed
+        * @param bool &$outputDone
+        * @param bool &$useParserCache
+        * @return bool
         */
        public function setPageContent( &$outputDone, &$useParserCache ) {
                $request = $this->getRequest();
@@ -418,8 +423,8 @@
        }
 
        /**
-        * @param $tag review box/bar info
-        * @param $prot protection notice
+        * @param string &$tag review box/bar info
+        * @param string $prot protection notice
         * Tag output function must be called by caller
         */
        protected function showUnreviewedPage( &$tag, $prot ) {
@@ -440,7 +445,7 @@
         * Tag output function must be called by caller
         * Parser cache control deferred to caller
         * @param FlaggedRevision $srev stable version
-        * @param string $tag review box/bar info
+        * @param string &$tag review box/bar info
         * @param string $prot protection notice icon
         * @return void
         */
@@ -556,7 +561,7 @@
         * Tag output function must be called by caller
         * Parser cache control deferred to caller
         * @param FlaggedRevision $frev selected flagged revision
-        * @param string $tag review box/bar info
+        * @param string &$tag review box/bar info
         * @param string $prot protection notice icon
         * @return ParserOutput
         */
@@ -626,7 +631,7 @@
         * Tag output function must be called by caller
         * Parser cache control deferred to caller
         * @param \FlaggedRevision|\stable $srev stable version
-        * @param string $tag review box/bar info
+        * @param string &$tag review box/bar info
         * @param string $prot protection notice
         * @return ParserOutput
         */
@@ -773,8 +778,8 @@
 
        /**
         * Get collapsible diff-to-stable html to add to the review notice as 
needed
-        * @param FlaggedRevision $srev, stable version
-        * @param bool $quality, revision is quality
+        * @param FlaggedRevision $srev stable version
+        * @param bool $quality revision is quality
         * @return string, the html line (either "" or "<diff toggle><diff 
div>")
         */
        protected function getTopDiffToggle( FlaggedRevision $srev, $quality ) {
@@ -865,6 +870,8 @@
         * If no stable version is required, the reference parameters will not 
be set
         *
         * Depends on $request
+        * @param File|null &$normalFile
+        * @param File|null &$displayFile
         */
        public function imagePageFindFile( &$normalFile, &$displayFile ) {
                $request = $this->getRequest();
@@ -995,6 +1002,8 @@
 
        /**
         * Adds stable version tags to page when editing
+        * @param EditPage $editPage
+        * @return bool
         */
        public function addToEditView( EditPage $editPage ) {
                global $wgParser;
@@ -1147,7 +1156,7 @@
         * Add review form to pages when necessary on a regular page view 
(action=view).
         * If $output is an OutputPage then this prepends the form onto it.
         * If $output is a string then this appends the review form to it.
-        * @param mixed string|OutputPage
+        * @param string|OutputPage &$output
         * @return bool
         */
        public function addReviewForm( &$output ) {
@@ -1260,6 +1269,9 @@
        /**
         * Modify an array of action links, as used by SkinTemplateNavigation 
and
         * SkinTemplateTabs, to inlude flagged revs UI elements
+        * @param Skin $skin
+        * @param array &$actions
+        * @return bool
         */
        public function setActionTabs( $skin, array &$actions ) {
                $reqUser = $this->getUser();
@@ -1294,7 +1306,7 @@
        /**
         * Modify an array of tab links to include flagged revs UI elements
         * @param Skin $skin
-        * @param array $views
+        * @param array &$views
         * @param string $type ('flat' for SkinTemplateTabs, 'nav' for 
SkinTemplateNavigation)
         * @return bool
         */
@@ -1440,7 +1452,7 @@
         * Adds a notice saying that this revision is pending review
         * @param FlaggedRevision $srev The stable version
         * @param string $diffToggle either "" or " <diff toggle><diff div>"
-        * @param boolean $background Whether to add the 'flaggedrevs_preview' 
CSS class
+        * @param bool $background Whether to add the 'flaggedrevs_preview' CSS 
class (the blue background)
         *   (the blue background)
         * @return void
         */
@@ -1473,7 +1485,7 @@
         *   (i)  Show a tag with some explanation for the diff
         *   (ii) List any template/file changes pending review
         *
-        * @param $diff
+        * @param string $diff
         * @param Revision $oldRev
         * @param Revision $newRev
         */
diff --git a/frontend/FlaggedRevsUI.hooks.php b/frontend/FlaggedRevsUI.hooks.php
index c5d8381..425ca68 100644
--- a/frontend/FlaggedRevsUI.hooks.php
+++ b/frontend/FlaggedRevsUI.hooks.php
@@ -48,7 +48,7 @@
 
        /**
         * Add FlaggedRevs css for relevant special pages.
-        * @param OutputPage $out
+        * @param OutputPage &$out
         * @return bool
         */
        protected static function injectStyleForSpecial( &$out ) {
@@ -90,6 +90,9 @@
 
        /**
         * Add user preferences (uses prefs-flaggedrevs, prefs-flaggedrevs-ui 
msgs)
+        * @param User $user
+        * @param array &$preferences
+        * @return true
         */
        public static function onGetPreferences( $user, array &$preferences ) {
                // Box or bar UI
@@ -284,7 +287,7 @@
         * through FlaggedRevs.
         *
         * @param SpecialPage $specialPage Special page
-        * @param array $filters Array of filters
+        * @param array &$filters Array of filters
         */
        public static function addHideReviewedUnstructuredFilter( $specialPage, 
&$filters ) {
                if ( !FlaggedRevs::useSimpleConfig() ) {
@@ -428,7 +431,6 @@
        /**
         * Add FlaggedRevs metadata by adding fields and joins
         *
-        * @param array &$conds Query conditions
         * @param array &$tables Tables to query
         * @param array &$join_conds Query join conditions
         * @param array &$fields Fields to query
@@ -526,7 +528,7 @@
         * Make stable version link and return the css
         * @param IContextSource $ctx
         * @param Title $title
-        * @param stdClass $row, from history page
+        * @param stdClass $row from history page
         * @return array (string,string)
         */
        protected static function markHistoryRow( IContextSource $ctx, Title 
$title, $row ) {
@@ -583,10 +585,10 @@
        /**
         * Intercept contribution entries and format them to FlaggedRevs 
standards
         *
-        * @param $contribs SpecialPage object for contributions
-        * @param $ret string the HTML line
-        * @param $row Row the DB row for this line
-        * @param $classes the classes to add to the surrounding <li>
+        * @param SpecialPage $contribs SpecialPage object for contributions
+        * @param string &$ret the HTML line
+        * @param stdClass $row Row the DB row for this line
+        * @param array &$classes the classes to add to the surrounding <li>
         * @return bool
         */
        public static function addToContribsLine( $contribs, &$ret, $row, 
&$classes ) {
diff --git a/frontend/FlaggedRevsUI.setup.php b/frontend/FlaggedRevsUI.setup.php
index 6f0f994..73dcffb 100644
--- a/frontend/FlaggedRevsUI.setup.php
+++ b/frontend/FlaggedRevsUI.setup.php
@@ -7,7 +7,7 @@
 class FlaggedRevsUISetup {
        /**
         * Register FlaggedRevs hooks.
-        * @param $hooks Array $wgHooks (assoc array of hooks and handlers)
+        * @param array &$hooks Array $wgHooks (assoc array of hooks and 
handlers)
         * @return void
         */
        public static function defineHookHandlers( array &$hooks ) {
@@ -50,7 +50,7 @@
 
        /**
         * Register FlaggedRevs special page cache updates as needed.
-        * @param array $updates $wgSpecialPageCacheUpdates (assoc array of 
special page updaters)
+        * @param array &$updates $wgSpecialPageCacheUpdates (assoc array of 
special page updaters)
         * @return void
         */
        public static function defineSpecialPageCacheUpdates( array &$updates ) 
{
diff --git a/frontend/FlaggedRevsXML.php b/frontend/FlaggedRevsXML.php
index db3eab2..7a9f181 100644
--- a/frontend/FlaggedRevsXML.php
+++ b/frontend/FlaggedRevsXML.php
@@ -15,8 +15,8 @@
 
        /**
         * Get a selector of reviewable namespaces
-        * @param int $selected, namespace selected
-        * @param $all Mixed: Value of an item denoting all namespaces, or null 
to omit
+        * @param int $selected namespace selected
+        * @param mixed $all Value of an item denoting all namespaces, or null 
to omit
         * @return string
         */
        public static function getNamespaceMenu( $selected = null, $all = null 
) {
@@ -56,8 +56,8 @@
 
        /**
         * Get a selector of review levels. Used for filters.
-        * @param int $selected, selected level
-        * @param string $all, all selector msg?
+        * @param int $selected selected level
+        * @param string $all all selector msg?
         * @param int $max max level?
         * @return string
         */
@@ -136,7 +136,7 @@
 
        /**
         * Get a selector of "approved"/"unapproved". Used for filters.
-        * @param int $selected, selected level
+        * @param int $selected selected level
         * @return string
         */
        public static function getStatusFilterMenu( $selected = null ) {
@@ -153,7 +153,7 @@
 
        /**
         * Get a selector of "auto"/"manual". Used for filters.
-        * @param int $selected, selected level
+        * @param int $selected selected level
         * @return string
         */
        public static function getAutoFilterMenu( $selected = null ) {
@@ -169,7 +169,7 @@
 
        /**
         * @param int $quality
-        * @return string, css color for this quality
+        * @return string css color for this quality
         */
        public static function getQualityColor( $quality ) {
                if ( $quality === false ) {
@@ -194,7 +194,7 @@
        /**
         * @param array $flags
         * @param bool $prettyBox
-        * @param string $css, class to wrap box in
+        * @param string $css class to wrap box in
         * @return string
         * Generates a review box/tag
         */
@@ -238,11 +238,11 @@
        }
 
        /**
-        * @param FlaggedRevision $frev, the reviewed version
+        * @param FlaggedRevision $frev the reviewed version
         * @param string $shtml Short message HTML
-        * @param int $revsSince, revisions since review
+        * @param int $revsSince revisions since review
         * @param string $type (stable/draft/oldstable)
-        * @param bool $synced, does stable=current and this is one of them?
+        * @param bool $synced does stable=current and this is one of them?
         * @return string
         * Generates a review box using a table using 
FlaggedRevsXML::addTagRatings()
         */
@@ -335,7 +335,7 @@
 
        /**
         * Generates (show/hide) JS toggle HTML
-        * @param  $href string|null If set, make the toggle link link to this 
URL and don't hide it
+        * @param string|null $href If set, make the toggle link link to this 
URL and don't hide it
         * @return string
         */
        public static function diffToggle( $href = null ) {
@@ -432,6 +432,10 @@
 
        /**
         * Same as pendingEditNotice(), but returns a Message object.
+        * @param FlaggableWikiPage $flaggedArticle
+        * @param FlaggedRevision $frev
+        * @param int $revsSince
+        * @return Message
         */
        public static function pendingEditNoticeMessage( $flaggedArticle, 
$frev, $revsSince ) {
                global $wgLang;
diff --git a/frontend/RevisionReviewFormUI.php 
b/frontend/RevisionReviewFormUI.php
index a4b466f..57bbcd8 100644
--- a/frontend/RevisionReviewFormUI.php
+++ b/frontend/RevisionReviewFormUI.php
@@ -265,9 +265,9 @@
 
        /**
         * @param User $user
-        * @param array $flags, selected flags
-        * @param bool $disabled, form disabled
-        * @param bool $reviewed, rev already reviewed
+        * @param array $flags selected flags
+        * @param bool $disabled form disabled
+        * @param bool $reviewed rev already reviewed
         * @return string
         * Generates a main tag inputs (checkboxes/radios/selects) for review 
form
         */
@@ -370,9 +370,9 @@
        /**
         * Generates review form submit buttons
         * @param int $rejectId left rev ID for "reject" on diffs
-        * @param FlaggedRevision $frev, the flagged revision, if any
-        * @param bool $disabled, is the form disabled?
-        * @param bool $reviewIncludes, force the review button to be usable?
+        * @param FlaggedRevision $frev the flagged revision, if any
+        * @param bool $disabled is the form disabled?
+        * @param bool $reviewIncludes force the review button to be usable?
         * @return string
         */
        protected static function submitButtons(
diff --git a/frontend/specialpages/reports/ProblemChanges_body.php 
b/frontend/specialpages/reports/ProblemChanges_body.php
index d832c63..820642a 100644
--- a/frontend/specialpages/reports/ProblemChanges_body.php
+++ b/frontend/specialpages/reports/ProblemChanges_body.php
@@ -257,8 +257,8 @@
 
        /**
         * Get the tags of the revisions of a page after a certain rev
-        * @param integer $pageId, page ID
-        * @param integer $revId, rev ID
+        * @param int $pageId page ID
+        * @param int $revId rev ID
         * @return Array
         */
        protected static function getChangeTags( $pageId, $revId ) {
diff --git a/phpcs.xml b/phpcs.xml
index b03fda8..7bde2b2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -8,7 +8,6 @@
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
                <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" 
/>
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
@@ -23,8 +22,6 @@
        <file>.</file>
        <arg name="extensions" value="php,php5,inc" />
        <arg name="encoding" value="UTF-8" />
-       <exclude-pattern>vendor</exclude-pattern>
-       <exclude-pattern>node_modules</exclude-pattern>
        <rule ref="MediaWiki.NamingConventions.ValidGlobalName">
                <properties>
                        <property name="ignoreList" type="array" 
value="$parserMemc,$mediaWiki" />

-- 
To view, visit https://gerrit.wikimedia.org/r/370824
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20e3e281bd5b17133b1d8b5fbdc10d7127c930d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to