Brion VIBBER has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370832 )
Change subject: Fix 'seeking' message in ogv.js on end of audio file ...................................................................... Fix 'seeking' message in ogv.js on end of audio file Use the 'seeked' event for end and don't trigger seeking mode when not seeking. Bug: T172888 Change-Id: I46bf5d4041ebaad648ca07e9e026fdd6699f4884 --- M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/32/370832/1 diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js index d523f99..44f3371 100644 --- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js +++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js @@ -197,12 +197,17 @@ this.currentTime = time; this.previousTime = time; // prevent weird double-seek. MwEmbedPlyer is weird! - // Run the onSeeking interface update - this.controlBuilder.onSeek(); - // @todo add proper events upstream if( this.seeking ){ - this.seeking = false; - $( this ).trigger( 'seeked' ); + // Run the onSeeking interface update + this.controlBuilder.onSeek(); + var _this = this; + function onseeked(event) { + _this.seeking = false; + _this.hideSpinner(); + $( _this ).trigger( 'seeked' ); + this.removeEventListener( 'seeked', onseeked ); + } + this.playerElement.addEventListener( 'seeked', onseeked ); } if ( $.isFunction( callback ) ) { callback(); -- To view, visit https://gerrit.wikimedia.org/r/370832 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46bf5d4041ebaad648ca07e9e026fdd6699f4884 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Brion VIBBER <br...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits