Elukey has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370842 )

Change subject: [UGLY-FIX] EventStreams: Double-quote `false` to avoid `False`
......................................................................


[UGLY-FIX] EventStreams: Double-quote `false` to avoid `False`

Scap uses Jinja2 directly, which converts values in a Pythonic way. That
causes corner cases such as `None` and `False` to appear in the config,
which are treated as strings in YAML (and hence Node.JS). This is a
work-around for EventStreams' rdkafka config option.

Bug: T172681
Bug: T145510
Change-Id: Iae96ececeb32c09853169e8e3426bb9ce31fe97c
---
M hieradata/role/common/scb.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Elukey: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/role/common/scb.yaml b/hieradata/role/common/scb.yaml
index cad864c..ccf580d 100644
--- a/hieradata/role/common/scb.yaml
+++ b/hieradata/role/common/scb.yaml
@@ -85,7 +85,7 @@
   # Specify Kafka API version as workaround for Brokers < 0.10
   # https://github.com/edenhill/librdkafka/wiki/Broker-version-compatibility
   # This will not be necessary when the target Kafka cluster will be running 
0.10
-  api.version.request: 'false'
+  api.version.request: '"false"'
   broker.version.fallback: '0.9.0.1'
 
 changeprop::restbase_uri: http://restbase-async.discovery.wmnet:7231

-- 
To view, visit https://gerrit.wikimedia.org/r/370842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae96ececeb32c09853169e8e3426bb9ce31fe97c
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to