Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53970
Change subject: (Bug 45559) - Clicking group selector does nothing until data
is loaded
......................................................................
(Bug 45559) - Clicking group selector does nothing until data is loaded
Change-Id: Iff833d51e3c893fca8e3e707589bf2971bf3752d
---
M resources/css/ext.translate.groupselector.css
M resources/js/ext.translate.groupselector.js
2 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/70/53970/1
diff --git a/resources/css/ext.translate.groupselector.css
b/resources/css/ext.translate.groupselector.css
index eb41318..110e9e0 100644
--- a/resources/css/ext.translate.groupselector.css
+++ b/resources/css/ext.translate.groupselector.css
@@ -248,3 +248,31 @@
min-height: 1px;
position: relative;
}
+
+@keyframes tux-loading-indicator-spin {
+ from {
+ transform: rotate(0deg);
+ }
+ to {
+ transform: rotate(360deg);
+ }
+}
+
+.ext-translate-msggroup-list.loading {
+ float: left;
+ background: transparent url(../images/loading.gif) right bottom
no-repeat;
+ background-image: -webkit-linear-gradient(transparent, transparent),
url(../images/loading.svg);
+ background-image: -moz-linear-gradient(transparent, transparent),
url(../images/loading.svg);
+ background-image: linear-gradient(transparent, transparent),
url(../images/loading.svg);
+ background-size: 10%;
+ -webkit-animation-name: tux-loading-indicator-spin;
+ -webkit-animation-duration: 1.5s;
+ -webkit-animation-iteration-count: infinite;
+ -webkit-animation-timing-function: linear;
+ animation-name: tux-loading-indicator-spin;
+ animation-duration: 1.5s;
+ animation-iteration-count: infinite;
+ animation-timing-function: linear;
+ height: 34px;
+ width: 34px;
+}
\ No newline at end of file
diff --git a/resources/js/ext.translate.groupselector.js
b/resources/js/ext.translate.groupselector.js
index 95ca953..88973ac 100644
--- a/resources/js/ext.translate.groupselector.js
+++ b/resources/js/ext.translate.groupselector.js
@@ -82,7 +82,7 @@
.append( $listFilters, $searchGroup );
$msgGroupList = $( '<div>' )
- .addClass( 'row ext-translate-msggroup-list' );
+ .addClass( 'row ext-translate-msggroup-list
loading' );
this.$menu.append( $groupTitle, $listFiltersGroup,
$msgGroupList );
@@ -276,6 +276,7 @@
if ( recentMessageGroups ) {
addRecentMessageGroups( recentMessageGroups );
} else {
+ $msgGroupList.addClass( 'loading' );
api.get( {
action: 'translateuser',
format: 'json'
@@ -283,6 +284,7 @@
$( '.ext-translate-msggroup-selector' )
.data( 'recentmsggroups',
result.translateuser.recentgroups );
addRecentMessageGroups(
result.translateuser.recentgroups );
+ $msgGroupList.removeClass( 'loading' );
} );
}
},
@@ -437,6 +439,8 @@
} else {
$msgGroupList.append( $msgGroupRows );
}
+
+ $msgGroupList.removeClass( 'loading' );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/53970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff833d51e3c893fca8e3e707589bf2971bf3752d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
