Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370870 )

Change subject: mw.util: Add a deprecation message to escapeId()
......................................................................

mw.util: Add a deprecation message to escapeId()

Bug: T172493
Change-Id: Ie1468a4c1b56ca79b5f978a8bba80e98d8871f51
---
M resources/src/mediawiki/mediawiki.util.js
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/370870/1

diff --git a/resources/src/mediawiki/mediawiki.util.js 
b/resources/src/mediawiki/mediawiki.util.js
index d0ec585..949adce 100644
--- a/resources/src/mediawiki/mediawiki.util.js
+++ b/resources/src/mediawiki/mediawiki.util.js
@@ -66,17 +66,6 @@
                rawurlencode: rawurlencode,
 
                /**
-                * Encode the string like Sanitizer::escapeId() in PHP
-                * @deprecated since 1.30 use escapeIdForAttribute() or 
escapeIdForLink()
-                *
-                * @param {string} str String to be encoded.
-                * @return {string} Encoded string
-                */
-               escapeId: function ( str ) {
-                       return escapeIdInternal( str, 'legacy' );
-               },
-
-               /**
                 * Encode string into HTML id compatible form suitable for use 
in HTML
                 * Analog to PHP Sanitizer::escapeIdForAttribute()
                 *
@@ -605,6 +594,18 @@
        }, 'Use mw.notify instead.' );
 
        /**
+        * Encode the string like Sanitizer::escapeId() in PHP
+        *
+        * @method
+        * @deprecated since 1.30 use escapeIdForAttribute() or 
escapeIdForLink()
+        * @param {string} str String to be encoded.
+        * @return {string} Encoded string
+        */
+       mw.log.deprecate( util, 'escapeId', function ( str ) {
+               return escapeIdInternal( str, 'legacy' );
+       }, 'Use mw.util.escapeIdForAttribute or mw.util.escapeIdForLink 
instead.' );
+
+       /**
         * Initialisation of mw.util.$content
         */
        function init() {

-- 
To view, visit https://gerrit.wikimedia.org/r/370870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1468a4c1b56ca79b5f978a8bba80e98d8871f51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to