Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370898 )

Change subject: Improve some parameter docs
......................................................................

Improve some parameter docs

Change-Id: I47e04c7e2b773d52289f459f59a46aeb9c4ad12e
---
M composer.json
M includes/Hooks.php
M phpcs.xml
3 files changed, 6 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LoginNotify 
refs/changes/98/370898/1

diff --git a/composer.json b/composer.json
index 7de1f1c..5204a3b 100644
--- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
        "scripts": {
                "fix": "phpcbf",
                "test": [
-                       "parallel-lint . --exclude vendor",
+                       "parallel-lint . --exclude vendor --exclude 
node_modules",
                        "phpcs -p -s"
                ]
        }
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 9685022..9ce77d8 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -88,7 +88,7 @@
 
        /**
         * @param EchoEvent $event
-        * @param string $bundleString
+        * @param string &$bundleString
         * @return bool
         */
        public static function onEchoGetBundleRules( EchoEvent $event, 
&$bundleString ) {
@@ -107,7 +107,7 @@
         *
         * @param User $user User in question.
         * @param string $pass The password (parameter not used).
-        * @param integer $retval A LoginForm constant (e.g. 
LoginForm::SUCCESS).
+        * @param int $retval A LoginForm constant (e.g. LoginForm::SUCCESS).
         */
        public static function onLoginAuthenticateAudit( User $user, $pass, 
$retval ) {
                if ( $retval === LoginForm::WRONG_PASS ) {
@@ -175,7 +175,7 @@
         *
         * @todo This still sets cookies if user creates an account while 
logged in as someone else.
         * @param User $user The user that has been created.
-        * @param boolean $byMail Account created by email
+        * @param bool $byMail Account created by email
         */
        public static function onAddNewAccount( User $user, $byMail ) {
                if ( !$byMail ) {
@@ -191,7 +191,7 @@
         *
         * @todo This still sets cookies if user creates account well logged in 
as someone else.
         * @param User $user User created
-        * @param boolean $autocreated Whether this was an auto-created account
+        * @param bool $autocreated Whether this was an auto-created account
         */
        public static function onLocalUserCreated( $user, $autocreated ) {
                if ( !$autocreated ) {
diff --git a/phpcs.xml b/phpcs.xml
index c2c9ce3..d1b5f11 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,11 +2,8 @@
 <ruleset>
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
        </rule>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc" />
-       <arg name="encoding" value="utf8" />
-       <exclude-pattern>vendor</exclude-pattern>
+       <arg name="encoding" value="UTF-8" />
 </ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/370898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47e04c7e2b773d52289f459f59a46aeb9c4ad12e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to