Daniel Kinzler has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53975


Change subject: (bug 45530) swicth to disable data transclusion
......................................................................

(bug 45530) swicth to disable data transclusion

Change-Id: I88105968ccf3536eeff184675b33edf8f9eb5829
---
M client/WikibaseClient.hooks.php
M client/config/WikibaseClient.default.php
M client/config/WikibaseClient.experimental.php
M docs/options.wiki
4 files changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/75/53975/1

diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 65007ec..9797c4f 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -406,7 +406,10 @@
         * @return bool
         */
        public static function onScribuntoExternalLibraries ( $engine, array 
&$extraLibraries ) {
-               $extraLibraries['mw.wikibase'] = 'Scribunto_LuaWikibaseLibrary';
+               if ( Settings::get( 'allowDataTransclusion' ) ) {
+                       $extraLibraries['mw.wikibase'] = 
'Scribunto_LuaWikibaseLibrary';
+               }
+
                return true;
        }
 
@@ -745,6 +748,10 @@
        public static function onParserFirstCallInit( &$parser ) {
                $parser->setFunctionHook( 'noexternallanglinks', 
'\Wikibase\NoLangLinkHandler::handle', SFH_NO_HASH );
 
+               if ( Settings::get( 'allowDataTransclusion' ) ) {
+                       $parser->setFunctionHook( 'property', array( 
'\Wikibase\PropertyParserFunction', 'render' ) );
+               }
+
                return true;
        }
 
diff --git a/client/config/WikibaseClient.default.php 
b/client/config/WikibaseClient.default.php
index 1a564c1..0a94227 100644
--- a/client/config/WikibaseClient.default.php
+++ b/client/config/WikibaseClient.default.php
@@ -57,7 +57,8 @@
        'repoNamespaces' => array(
                'wikibase-item' => '',
                'wikibase-property' => 'Property'
-       )
+       ),
+       'allowDataTransclusion' => true,
 );
 
 /**
diff --git a/client/config/WikibaseClient.experimental.php 
b/client/config/WikibaseClient.experimental.php
index 84e15ef..e3844c3 100644
--- a/client/config/WikibaseClient.experimental.php
+++ b/client/config/WikibaseClient.experimental.php
@@ -52,9 +52,3 @@
 
        return true;
 };
-
-$wgHooks['ParserFirstCallInit'][] = function( \Parser &$parser ) {
-       $parser->setFunctionHook( 'property', array( 
'\Wikibase\PropertyParserFunction', 'render' ) );
-
-       return true;
-};
diff --git a/docs/options.wiki b/docs/options.wiki
index 705b763..705060d 100644
--- a/docs/options.wiki
+++ b/docs/options.wiki
@@ -86,6 +86,7 @@
               'wikibase-property' => 'Property'
           )
 </poem>
+;allowDataTransclusion: switch to enable data transclusion features like the 
<nowiki>{{#property}}</nowiki> parser function and the <tt>wikibase</tt> 
Scribunto module. Defaults to <tt>true</tt>.
 
 === Expert Settings ===
 ;siteGroup: This site's group ID, as used in the sites table. Default: 
<tt>'wikipedia'</tt>. '''Note:''' this setting will be removed once we can take 
this information from the sites table.

-- 
To view, visit https://gerrit.wikimedia.org/r/53975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88105968ccf3536eeff184675b33edf8f9eb5829
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to