Elukey has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370786 )

Change subject: statistics::package: add missing package depencency
......................................................................


statistics::package: add missing package depencency

Puppet on notebook hosts is failing because apt::pin
is required to wait for packages that are not listed
in the catalog.

Bug: T171924
Change-Id: If0d3510bb7c28398862b70c3cbbe1da926ab3e06
---
M modules/statistics/manifests/packages.pp
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Elukey: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/statistics/manifests/packages.pp 
b/modules/statistics/manifests/packages.pp
index 6389454..8e6b724 100644
--- a/modules/statistics/manifests/packages.pp
+++ b/modules/statistics/manifests/packages.pp
@@ -141,6 +141,13 @@
             'r-cran-rmysql',
             'r-recommended'    # CRAN-recommended packages (e.g. MASS, Matrix, 
boot)
         ]
+
+        # Explicitly list package dependencies, instead of using 
require_package,
+        # to avoid dependency issues with the 'before' clause in apt::pin.
+        package { $r_packages:
+            ensure => present,
+        }
+
         apt::pin { $r_packages:
             pin      => 'release a=jessie-backports',
             priority => '1001',

-- 
To view, visit https://gerrit.wikimedia.org/r/370786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0d3510bb7c28398862b70c3cbbe1da926ab3e06
Gerrit-PatchSet: 7
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to