Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370999 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I02c9c424e8deb41ef7d727b227b875a086bdfff5
---
M PageAssessments.hooks.php
M PageAssessmentsBody.php
M composer.json
M phpcs.xml
4 files changed, 11 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments
refs/changes/99/370999/1
diff --git a/PageAssessments.hooks.php b/PageAssessments.hooks.php
index 584d4e8..fae597b 100644
--- a/PageAssessments.hooks.php
+++ b/PageAssessments.hooks.php
@@ -24,7 +24,7 @@
/**
* Register the parser function hook
- * @param $parser Parser
+ * @param Parser &$parser
*/
public static function onParserFirstCallInit( &$parser ) {
$parser->setFunctionHook( 'assessment',
'PageAssessmentsBody::cacheAssessment' );
@@ -32,7 +32,7 @@
/**
* Update assessment records after talk page is saved
- * @param LinksUpdate $linksUpdate
+ * @param LinksUpdate &$linksUpdate
* @param mixed $ticket
*/
public static function onLinksUpdateComplete( &$linksUpdate, $ticket =
null ) {
@@ -77,6 +77,12 @@
/**
* Delete assessment records when page is deleted
+ * @param Article &$article
+ * @param User &$user
+ * @param string $reason
+ * @param int $id
+ * @param Content $content
+ * @param LogEntry $logEntry
*/
public static function onArticleDeleteComplete(
&$article, &$user, $reason, $id, $content = null, $logEntry
diff --git a/PageAssessmentsBody.php b/PageAssessmentsBody.php
index de2c05a..e5ae6d8 100644
--- a/PageAssessmentsBody.php
+++ b/PageAssessmentsBody.php
@@ -125,7 +125,7 @@
/**
* Get name for the given wikiproject
- * @param integer $projectId The ID of the project
+ * @param int $projectId The ID of the project
* @return string|false The name of the project or false if not found
*/
public static function getProjectName( $projectId ) {
@@ -322,7 +322,7 @@
/**
* Function called on parser init
- * @param Parser $parser Parser object
+ * @param Parser &$parser Parser object
* @param string $project Wikiproject name
* @param string $class Class of article
* @param string $importance Importance of article
diff --git a/composer.json b/composer.json
index 834ad8e..f175d8d 100644
--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,7 @@
},
"scripts": {
"test": [
- "parallel-lint . --exclude vendor",
+ "parallel-lint . --exclude vendor --exclude
node_modules",
"phpcs -p -s"
],
"fix": [
diff --git a/phpcs.xml b/phpcs.xml
index c4e2dec..30d35e8 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,9 +2,6 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"
/>
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
--
To view, visit https://gerrit.wikimedia.org/r/370999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02c9c424e8deb41ef7d727b227b875a086bdfff5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
