Pwirth has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371007 )

Change subject: BSPageTemplates: Removed outdated bugfix
......................................................................

BSPageTemplates: Removed outdated bugfix

Until MW 1.17 '<noinclude>' tags where not stripped ped 'preload' situations.
So a bugfix was implemented. Nowadays this problem is fixed in MW core and
the former bugfix is now a bug.

See 
https://www.mediawiki.org/wiki/Manual:Creating_pages_with_preloaded_text#Loading_the_preload_file

NEEDS CHERRY-PICK TO REL1_27 AND REL1_23

Change-Id: I3eb214ce80d686a5da2fb4788827f80c0859a608
---
M PageTemplates/PageTemplates.class.php
1 file changed, 0 insertions(+), 15 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/07/371007/1

diff --git a/PageTemplates/PageTemplates.class.php 
b/PageTemplates/PageTemplates.class.php
index b6ce4d4..78228c8 100644
--- a/PageTemplates/PageTemplates.class.php
+++ b/PageTemplates/PageTemplates.class.php
@@ -56,7 +56,6 @@
 
                //Hooks
                $this->setHook( 'LinkBegin' );
-               $this->setHook( 'EditPage::showEditForm:initial', 
'onEditPageShowEditFormInitial' );
                $this->setHook( 'MessagesPreLoad' );
                $this->setHook( 'ParserFirstCallInit' );
 
@@ -209,20 +208,6 @@
 
                if ( !isset( $aQuery['preload'] ) ) {
                        $aQuery['action'] = 'view';
-               }
-
-               return true;
-       }
-
-       /**
-        * Removes noinclude parts from templates
-        * @param EditPage $oEdit MediaWiki EditPage object
-        * @return bool allow other hooked methods to be executed. Always true.
-        */
-       function onEditPageShowEditFormInitial( &$oEdit ) {
-               if ( RequestContext::getMain()->getRequest()->getVal( 
'preload', '' ) ) {
-                       // TODO MRG (27.09.11 10:28): Put replacement of 
noinclude into core
-                       $oEdit->textbox1 = preg_replace( 
'/<noinclude>.*?<\/noinclude>/s', '',  $oEdit->textbox1 );
                }
 
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/371007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eb214ce80d686a5da2fb4788827f80c0859a608
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_27
Gerrit-Owner: Pwirth <wi...@hallowelt.biz>
Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to