jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371003 )

Change subject: Improve some parameter docs
......................................................................


Improve some parameter docs

Change-Id: Ic78a889eb7374731a282312c9eadb701483ae298
---
M composer.json
M includes/UserPreferencesChangeHandler.php
M phpcs.xml
3 files changed, 6 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/composer.json b/composer.json
index 55507be..91c6304 100644
--- a/composer.json
+++ b/composer.json
@@ -6,7 +6,7 @@
        },
        "scripts": {
                "test": [
-                       "parallel-lint . --exclude vendor",
+                       "parallel-lint . --exclude vendor --exclude 
node_modules",
                        "phpcs -p -s"
                ],
                "fix": [
diff --git a/includes/UserPreferencesChangeHandler.php 
b/includes/UserPreferencesChangeHandler.php
index ccd3770..ee80b48 100644
--- a/includes/UserPreferencesChangeHandler.php
+++ b/includes/UserPreferencesChangeHandler.php
@@ -74,7 +74,7 @@
         * @param array $formData Form data submitted by user
         * @param PreferencesForm $form A preferences form
         * @param User $user Logged-in user
-        * @param boolean &$result Variable defining is form save successful
+        * @param bool &$result Variable defining is form save successful
         * @param array $oldUserOptions Old user options array
         */
        public static function onPreferencesFormPreSave(
diff --git a/phpcs.xml b/phpcs.xml
index 7255308..1a3c9e9 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,17 +1,15 @@
 <?xml version="1.0"?>
 <ruleset>
-       <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
-       </rule>
+       <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc" />
-       <arg name="encoding" value="utf8" />
-       <exclude-pattern>vendor</exclude-pattern>
+       <arg name="encoding" value="UTF-8" />
 
        <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
                <properties>
                        <property name="equalsSpacing" value="1" />
-                               <property name="requiredSpacesAfterOpen" 
value="1" />
-                               <property name="requiredSpacesBeforeClose" 
value="1" />
+                       <property name="requiredSpacesAfterOpen" value="1" />
+                       <property name="requiredSpacesBeforeClose" value="1" />
                </properties>
        </rule>
 </ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/371003
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic78a889eb7374731a282312c9eadb701483ae298
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to