Giuseppe Lavagetto has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371023 )

Change subject: profile::docker::storage: fix guard around vg_to_remove
......................................................................

profile::docker::storage: fix guard around vg_to_remove

This way, the test will work with the future parser as well.

Change-Id: I0bf15cdc4ad9bbfef3e6419d51b1d46299016daf
---
M modules/profile/manifests/docker/storage.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/23/371023/1

diff --git a/modules/profile/manifests/docker/storage.pp 
b/modules/profile/manifests/docker/storage.pp
index f253f36..7137073 100644
--- a/modules/profile/manifests/docker/storage.pp
+++ b/modules/profile/manifests/docker/storage.pp
@@ -19,7 +19,7 @@
 
     Class['::profile::docker::storage'] -> Service['docker']
 
-    if $vg_to_remove {
+    if ($vg_to_remove  and ! empty($vg_to_remove)) {
         volume_group { $vg_to_remove:
             ensure           => absent,
             physical_volumes => [],

-- 
To view, visit https://gerrit.wikimedia.org/r/371023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bf15cdc4ad9bbfef3e6419d51b1d46299016daf
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to