jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371024 )

Change subject: Use .length instead of .size() as it's getting removed in 
jQuery 3.0
......................................................................


Use .length instead of .size() as it's getting removed in jQuery 3.0

Bug: T169385
Change-Id: I86d0a9414960a190e4eda1e732b2530110287a55
---
M resources/js/ext.translate.quickedit.js
M resources/js/ext.translate.special.languagestats.js
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/resources/js/ext.translate.quickedit.js 
b/resources/js/ext.translate.quickedit.js
index 3e4f93e..8b7a512 100644
--- a/resources/js/ext.translate.quickedit.js
+++ b/resources/js/ext.translate.quickedit.js
@@ -201,7 +201,7 @@
                        id = 'jsedit' + page.replace( /[^a-zA-Z0-9_]/g, '_' );
                        dialogElement = $( '#' + id );
 
-                       if ( dialogElement.size() > 0 ) {
+                       if ( dialogElement.length > 0 ) {
                                dialogElement.dialog( 'option', 'position', 
'top' );
                                dialogElement.dialog( 'open' );
                                return false;
diff --git a/resources/js/ext.translate.special.languagestats.js 
b/resources/js/ext.translate.special.languagestats.js
index c01920e..24800d7 100644
--- a/resources/js/ext.translate.special.languagestats.js
+++ b/resources/js/ext.translate.special.languagestats.js
@@ -14,7 +14,7 @@
                        $metaRows = $( 'tr.AggregateMessageGroup', 
$translateTable );
 
                // Quick return
-               if ( !$metaRows.size() ) {
+               if ( !$metaRows.length ) {
                        return;
                }
 
@@ -25,7 +25,7 @@
                                $children = $( 'tr[data-parentgroup="' + 
thisGroupId + '"]', $translateTable );
 
                        // Only do the collapse stuff if this Meta-group 
actually has children on this page
-                       if ( !$children.size() ) {
+                       if ( !$children.length ) {
                                return;
                        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86d0a9414960a190e4eda1e732b2530110287a55
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to