jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371037 )

Change subject: Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove
......................................................................


Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

Replaced method in jQuery 3.

Bug: T169387
Change-Id: Ic456700c3e685aa67727f38e5002318da4ade52a
---
M resources/ext.wikiLove.core.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.wikiLove.core.js b/resources/ext.wikiLove.core.js
index 1dfa64b..7b1f1b2 100644
--- a/resources/ext.wikiLove.core.js
+++ b/resources/ext.wikiLove.core.js
@@ -835,7 +835,7 @@
                } else { // legacy skins
                        $wikiLoveLink = $( '#topbar a:contains(' + mw.msg( 
'wikilove-tab-text' ) + ')' );
                }
-               $wikiLoveLink.unbind( 'click' );
+               $wikiLoveLink.off( 'click' );
                $wikiLoveLink.click( function ( e ) {
                        e.preventDefault();
                        $.wikiLove.openDialog();

-- 
To view, visit https://gerrit.wikimedia.org/r/371037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic456700c3e685aa67727f38e5002318da4ade52a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLove
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to