jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370860 )

Change subject: Use prop instead of removeAttr for submit button disabled status
......................................................................


Use prop instead of removeAttr for submit button disabled status

Change-Id: Ida2f07ff0220bd3ead3140c6b5c3539282f6e5a0
---
M modules/ext.wikihiero.Special.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ext.wikihiero.Special.js b/modules/ext.wikihiero.Special.js
index aea5536..47aaeca 100644
--- a/modules/ext.wikihiero.Special.js
+++ b/modules/ext.wikihiero.Special.js
@@ -7,9 +7,9 @@
 
        $textarea.keyup( function () {
                if ( $textarea.val().length === 0 ) {
-                       $submit.attr( 'disabled', 'disabled' );
+                       $submit.prop( 'disabled', true );
                } else {
-                       $submit.removeAttr( 'disabled' );
+                       $submit.prop( 'disabled', false );
                }
        } );
        $textarea.keyup();

-- 
To view, visit https://gerrit.wikimedia.org/r/370860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida2f07ff0220bd3ead3140c6b5c3539282f6e5a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/wikihiero
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to