jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371016 )

Change subject: Use .length instead of .size() as it's getting removed in 
jQuery 3.0
......................................................................


Use .length instead of .size() as it's getting removed in jQuery 3.0

Bug: T169385
Change-Id: I572d1d93c03abe8bd604ff0c099dfd4558ac8ce6
---
M modules/ext.codereview.overview.js
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ext.codereview.overview.js 
b/modules/ext.codereview.overview.js
index 1368835..715cd8c 100644
--- a/modules/ext.codereview.overview.js
+++ b/modules/ext.codereview.overview.js
@@ -12,8 +12,8 @@
        "use strict";
 
        // check if we're on a page with a useful list of revisions
-       if ( $( '#path' ).size() && $( 'table.TablePager' ).size() ) {
-               var portlet = $( '#p-namespaces' ).size() ? 'p-namespaces' : 
'p-cactions';
+       if ( $( '#path' ).length && $( 'table.TablePager' ).length ) {
+               var portlet = $( '#p-namespaces' ).length ? 'p-namespaces' : 
'p-cactions';
                mw.util.addPortletLink(
                        portlet,
                        '#',
@@ -25,9 +25,9 @@
 
        $( '#ca-scapmap' ).click( function () {
                var $tr = $( 'table.TablePager tr' );
-               if ( $tr.size() < 2 ) {
+               if ( $tr.length < 2 ) {
                        return;
-               } else if ( $( '#overviewmap' ).size() ) {
+               } else if ( $( '#overviewmap' ).length ) {
                        // We've already created it; maybe they just want to 
toggle it on and off
                        $( '#overviewmap' ).slideToggle();
                        return;
@@ -100,11 +100,11 @@
                }
                sumtext.sort();
                var $summary = $( '<div class="summary">' )
-                       .text( 'Total revisions: ' + ( $tr.size() - 1 ) + '. [' 
+ sumtext.join( ', ' ) + ']' );
+                       .text( 'Total revisions: ' + ( $tr.length - 1 ) + '. [' 
+ sumtext.join( ', ' ) + ']' );
 
                $( '#overviewmap' )
                        .append( $summary )
-                       .css( 'max-width', Math.floor( Math.sqrt( $tr.size() ) 
) * 30 )
+                       .css( 'max-width', Math.floor( Math.sqrt( $tr.length ) 
) * 30 )
                        .slideDown();
 
                // Add the hover popup

-- 
To view, visit https://gerrit.wikimedia.org/r/371016
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I572d1d93c03abe8bd604ff0c099dfd4558ac8ce6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to