Giuseppe Lavagetto has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371066 )

Change subject: Rakefile: run syntax checks in sequence
......................................................................

Rakefile: run syntax checks in sequence

It appears that there is some thread-safety issue that can make one or
multiple tasks fail when running in with multitask.

Change-Id: Ibbee7bf38441172f9d97c3e171d4a004f00ec8ce
---
M Rakefile
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/66/371066/1

diff --git a/Rakefile b/Rakefile
index 03d5e71..44d87ce 100644
--- a/Rakefile
+++ b/Rakefile
@@ -217,7 +217,9 @@
     return tasks if tasks.empty?
     # Now re-set up the jobs by instantiating the class
     PuppetSyntax::RakeTask.new
-    tasks
+    # The jobs we select here need to be run in sequence for some 
thread-safety reasons
+    task :syntax_all => tasks
+    [:syntax_all]
   end
 
   def setup_rubocop

-- 
To view, visit https://gerrit.wikimedia.org/r/371066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbee7bf38441172f9d97c3e171d4a004f00ec8ce
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to