jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370821 )
Change subject: Improve some parameter docs ...................................................................... Improve some parameter docs Change-Id: I526ad63486fe42e1f1dc8162e3457c8f19ee2fe8 --- M EducationProgram.hooks.php M includes/ArticleStore.php M includes/FailForm.php M includes/OrgDeletionHelper.php M includes/RevisionAction.php M includes/RoleObject.php M includes/UserMergeArticleReviewersJob.php M includes/Utils.php M includes/actions/EditAction.php M includes/actions/EditCourseAction.php M includes/actions/ViewAction.php M includes/api/ApiEnlist.php M includes/notifications/NotificationsManager.php M includes/pagers/ArticleTable.php M includes/pagers/CoursePager.php M includes/pagers/EPPager.php M includes/rows/Course.php M includes/rows/EPRevision.php M includes/rows/RevisionedObject.php M includes/rows/Student.php M includes/specials/SpecialAmbassadorProfile.php M includes/specials/SpecialEducationProgram.php M includes/specials/SpecialStudentActivity.php M includes/specials/VerySpecialPage.php M includes/tables/Courses.php M includes/tables/Orgs.php M includes/tables/PageTable.php M maintenance/importWEPData.php M maintenance/importWEPFromDB.php M phpcs.xml 30 files changed, 102 insertions(+), 104 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/EducationProgram.hooks.php b/EducationProgram.hooks.php index 9c4a898..fe8b57c 100755 --- a/EducationProgram.hooks.php +++ b/EducationProgram.hooks.php @@ -44,7 +44,7 @@ } /** - * @param \ResourceLoader $resourceLoader + * @param \ResourceLoader &$resourceLoader */ public static function onResourceLoaderRegisterModules( \ResourceLoader &$resourceLoader ) { $extraDependancies = []; @@ -128,8 +128,8 @@ * * @since 0.1 * - * @param array $personal_urls - * @param Title $title + * @param array &$personal_urls + * @param Title &$title */ public static function onPersonalUrls( array &$personal_urls, Title &$title ) { if ( Settings::get( 'enableTopLink' ) ) { @@ -158,7 +158,7 @@ * @since 0.1 * * @param User $user - * @param array $preferences + * @param array &$preferences */ public static function onGetPreferences( User $user, array &$preferences ) { if ( Settings::get( 'enableTopLink' ) ) { @@ -192,8 +192,8 @@ * * @since 0.1 * - * @param Title $title - * @param \Article|null $article + * @param Title &$title + * @param \Article|null &$article */ public static function onArticleFromTitle( Title &$title, &$article ) { if ( $title->getNamespace() == EP_NS ) { @@ -207,7 +207,7 @@ * * @since 0.1 * - * @param array $list + * @param array &$list */ public static function onCanonicalNamespaces( array &$list ) { $list[EP_NS] = 'Education_Program'; @@ -220,8 +220,8 @@ * * @since 0.1 * - * @param SkinTemplate $sktemplate - * @param array $links + * @param SkinTemplate &$sktemplate + * @param array &$links */ public static function onPageTabs( SkinTemplate &$sktemplate, array &$links ) { self::displayTabs( $sktemplate, $links, $sktemplate->getTitle() ); @@ -233,8 +233,8 @@ * * @since 0.1 * - * @param SkinTemplate $sktemplate - * @param array $links + * @param SkinTemplate &$sktemplate + * @param array &$links */ public static function onSpecialPageTabs( SkinTemplate &$sktemplate, array &$links ) { $textParts = \SpecialPageFactory::resolveAlias( $sktemplate->getTitle()->getText() ); @@ -266,8 +266,8 @@ * * @since 0.1 * - * @param SkinTemplate $sktemplate - * @param array $links + * @param SkinTemplate &$sktemplate + * @param array &$links * @param Title $title */ protected static function displayTabs( @@ -363,7 +363,7 @@ * @since 0.1 * * @param Title $title - * @param boolean|null $isKnown + * @param bool|null &$isKnown */ public static function onTitleIsAlwaysKnown( Title $title, &$isKnown ) { if ( $title->getNamespace() == EP_NS ) { @@ -402,7 +402,7 @@ * @param Title $oldTitle * @param Title $newTitle * @param User $user - * @param string $error + * @param string &$error * @param string $reason * * @return bool @@ -425,8 +425,8 @@ * * @since 0.1 * - * @param integer $index - * @param boolean $movable + * @param int $index + * @param bool &$movable */ public static function onNamespaceIsMovable( $index, &$movable ) { if ( in_array( $index, [ EP_NS, EP_NS_TALK ] ) ) { @@ -442,7 +442,7 @@ * * @param Page $article * @param Revision $rev - * @param integer $baseID + * @param int $baseID * @param User $user */ public static function onNewRevisionFromEditComplete( @@ -502,9 +502,9 @@ * * @since 0.4 alpha * - * @param array $notifications - * @param array $notificationCategories - * @param array $icons + * @param array &$notifications + * @param array &$notificationCategories + * @param array &$icons */ public static function onBeforeCreateEchoEvent( array &$notifications, @@ -524,8 +524,8 @@ * * @since 0.4 alpha * - * @param $event EchoEvent - * @param $users array + * @param EchoEvent $event + * @param array &$users */ public static function onEchoGetDefaultNotifiedUsers( EchoEvent $event, @@ -592,7 +592,7 @@ /** * Let UserMerge know which of our tables need updating * - * @param array $fields + * @param array &$fields * * @since 0.5.0 alpha */ @@ -614,7 +614,7 @@ * If the above tables had unique key conflicts, just delete the conflicting * rows. * - * @param array $tables + * @param array &$tables * * @since 0.5.0 alpha */ @@ -630,7 +630,7 @@ } /** - * @param User $oldUser + * @param User &$oldUser * @param User $newUser * @return bool * diff --git a/includes/ArticleStore.php b/includes/ArticleStore.php index 3eb1312..5202355 100644 --- a/includes/ArticleStore.php +++ b/includes/ArticleStore.php @@ -109,7 +109,7 @@ * * @param EPArticle $article * - * @return int|boolean The id for the inserted article or false on failure + * @return int|bool The id for the inserted article or false on failure * @throws InvalidArgumentException */ public function insertArticle( EPArticle $article ) { diff --git a/includes/FailForm.php b/includes/FailForm.php index eb63702..a0e10c0 100644 --- a/includes/FailForm.php +++ b/includes/FailForm.php @@ -28,20 +28,20 @@ /** * Should the summary field be shown or not? * @since 0.1 - * @var boolean + * @var bool */ protected $showSummary = true; /** * Should the minor edit checkbox be shown or not? * @since 0.1 - * @var boolean + * @var bool */ protected $showMinorEdit = true; /** * Wrap the form innards in an actual <form> element - * @param $html String HTML contents to wrap. + * @param string $html HTML contents to wrap. * @return String wrapped HTML. */ function wrapForm( $html ) { @@ -83,7 +83,7 @@ * * @since 0.1 * - * @param boolean $showSummary + * @param bool $showSummary */ public function setShowSummary( $showSummary ) { $this->showSummary = $showSummary; @@ -94,7 +94,7 @@ * * @since 0.1 * - * @param boolean $showMinorEdit + * @param bool $showMinorEdit */ public function setShowMinorEdit( $showMinorEdit ) { $this->showMinorEdit = $showMinorEdit; diff --git a/includes/OrgDeletionHelper.php b/includes/OrgDeletionHelper.php index 2ce6ac2..ceab8f4 100644 --- a/includes/OrgDeletionHelper.php +++ b/includes/OrgDeletionHelper.php @@ -105,7 +105,7 @@ * Create an associative array with info (message key and params) for * a message explaining why an institution can't be deleted. * - * @param boolean $plain + * @param bool $plain * * @return array * diff --git a/includes/RevisionAction.php b/includes/RevisionAction.php index 0858a8f..16e9740 100644 --- a/includes/RevisionAction.php +++ b/includes/RevisionAction.php @@ -82,7 +82,7 @@ /** * @since 0.1 - * @param boolean $isDelete + * @param bool $isDelete */ public function setDelete( $isDelete ) { $this->isDelete = $isDelete; @@ -90,7 +90,7 @@ /** * @since 0.1 - * @param boolean $isMinor + * @param bool $isMinor */ public function setMinor( $isMinor ) { $this->isMinor = $isMinor; diff --git a/includes/RoleObject.php b/includes/RoleObject.php index 01979b4..c8215d6 100644 --- a/includes/RoleObject.php +++ b/includes/RoleObject.php @@ -38,8 +38,8 @@ * * @since 0.1 * - * @param integer $userId - * @param boolean $load If the object should be loaded from the db if it already exists + * @param int $userId + * @param bool $load If the object should be loaded from the db if it already exists * @param null|array|string $fields Fields to load * * @return RoleObject @@ -73,7 +73,7 @@ * @since 0.1 * * @param User $user - * @param boolean $load If the object should be loaded from the db if it already exists + * @param bool $load If the object should be loaded from the db if it already exists * @param null|array|string $fields Fields to load * * @return RoleObject @@ -271,7 +271,7 @@ * * @since 0.1 * - * @return integer, part of EP_ enum. + * @return int Part of EP_ enum. */ protected function getRoleId() { $map = [ @@ -309,7 +309,7 @@ * * @since 0.3 * - * @param integer $courseId + * @param int $courseId * @param string $role */ public function onEnrolled( $courseId, $role ) { diff --git a/includes/UserMergeArticleReviewersJob.php b/includes/UserMergeArticleReviewersJob.php index 2befda6..fdeeea8 100644 --- a/includes/UserMergeArticleReviewersJob.php +++ b/includes/UserMergeArticleReviewersJob.php @@ -84,7 +84,7 @@ /** * Usermerge in an array of ids. Returns true if there were changes. * - * @param int[] $ids + * @param int[] &$ids * @param int $oldId * @param int $newId * diff --git a/includes/Utils.php b/includes/Utils.php index fff098e..30145c5 100644 --- a/includes/Utils.php +++ b/includes/Utils.php @@ -155,7 +155,7 @@ * * @since 0.1 * - * @param integer $userId + * @param int $userId * @param string $userName * @param IContextSource $context * @param array $extraLinks diff --git a/includes/actions/EditAction.php b/includes/actions/EditAction.php index 354443d..64981cf 100644 --- a/includes/actions/EditAction.php +++ b/includes/actions/EditAction.php @@ -33,7 +33,7 @@ * If the action is in insert mode rather then edit mode. * * @since 0.1 - * @var boolean|null + * @var bool|null */ protected $isNew = null; @@ -382,7 +382,7 @@ * * @since 0.1 * - * @param boolean $addedItem + * @param bool $addedItem * * @return Title */ @@ -487,7 +487,7 @@ /** * @since 0.2 * - * @param array $fields + * @param array &$fields */ protected function handleKnownFields( array &$fields ) { } diff --git a/includes/actions/EditCourseAction.php b/includes/actions/EditCourseAction.php index 9251c29..3445bb5 100644 --- a/includes/actions/EditCourseAction.php +++ b/includes/actions/EditCourseAction.php @@ -365,7 +365,7 @@ * @since 0.2 * * @param string $courseName - * @param string|integer $orgId + * @param string|int $orgId * * @return string */ @@ -384,7 +384,7 @@ * * @since 0.2 * - * @param array $fields + * @param array &$fields */ protected function handleKnownFields( array &$fields ) { // Set fields that are needed, but immutable diff --git a/includes/actions/ViewAction.php b/includes/actions/ViewAction.php index 8ffcc94..16ce0f1 100644 --- a/includes/actions/ViewAction.php +++ b/includes/actions/ViewAction.php @@ -200,7 +200,7 @@ * @since 0.1 * * @param IORMRow $item - * @param boolean $collapsed + * @param bool $collapsed * @param array $summaryData * * @return string diff --git a/includes/api/ApiEnlist.php b/includes/api/ApiEnlist.php index 7cc27d2..37ea8dc 100644 --- a/includes/api/ApiEnlist.php +++ b/includes/api/ApiEnlist.php @@ -117,7 +117,7 @@ * * @since 0.1 * - * @param integer $userId User id of the mentor affected + * @param int $userId User id of the mentor affected * @param string $role * @param string $subAction * diff --git a/includes/notifications/NotificationsManager.php b/includes/notifications/NotificationsManager.php index b7dcc3d..9ee9d0a 100644 --- a/includes/notifications/NotificationsManager.php +++ b/includes/notifications/NotificationsManager.php @@ -72,9 +72,9 @@ * * @since 0.4 alpha * - * @param array $notifications - * @param array $notificationCategories - * @param array $icons + * @param array &$notifications + * @param array &$notificationCategories + * @param array &$icons */ public function setUpTypesAndCategories( array &$notifications, @@ -114,8 +114,8 @@ * * @since 0.4 alpha * - * @param $event \EchoEvent - * @param $users array + * @param \EchoEvent $event + * @param array &$users */ public function getUsersNotified( \EchoEvent $event, array &$users ) { $key = $event->getType(); diff --git a/includes/pagers/ArticleTable.php b/includes/pagers/ArticleTable.php index 9f28dcd..6ff06a1 100644 --- a/includes/pagers/ArticleTable.php +++ b/includes/pagers/ArticleTable.php @@ -68,7 +68,7 @@ * Show the students column or not. * * @since 0.1 - * @var boolean + * @var bool */ protected $showStudents = true; @@ -100,7 +100,7 @@ * * @since 0.1 * - * @param boolean $showStudents + * @param bool $showStudents */ public function setShowStudents( $showStudents ) { $this->showStudents = $showStudents; @@ -231,7 +231,7 @@ * * @param string &$html * @param EPArticle[] $articles - * @param boolean $showArticleAddition + * @param bool $showArticleAddition * @param int $studentUserId */ protected function addNonStudentHTML( @@ -299,8 +299,8 @@ * * @since 0.1 * - * @param integer $userId - * @param integer $rowSpan + * @param int $userId + * @param int $rowSpan * * @return string */ @@ -373,7 +373,7 @@ * @since 0.1 * * @param EPArticle $article - * @param integer $rowSpan + * @param int $rowSpan * * @return string */ @@ -449,7 +449,7 @@ * @since 0.1 * * @param EPArticle $article - * @param integer $userId User id of the reviewer + * @param int $userId User id of the reviewer * * @return string */ @@ -518,7 +518,7 @@ * * @since 0.1 * - * @param integer $courseId + * @param int $courseId * @param int $studentUserId * * @return string diff --git a/includes/pagers/CoursePager.php b/includes/pagers/CoursePager.php index 4a9d5a4..64b0aee 100644 --- a/includes/pagers/CoursePager.php +++ b/includes/pagers/CoursePager.php @@ -20,7 +20,7 @@ * When in read only mode, the pager should not show any course editing controls. * * @since 0.1 - * @var boolean + * @var bool */ protected $readOnlyMode; @@ -36,7 +36,7 @@ /** * @param IContextSource $context * @param array $conds - * @param boolean $readOnlyMode + * @param bool $readOnlyMode */ public function __construct( IContextSource $context, array $conds = [], $readOnlyMode = false @@ -63,7 +63,7 @@ * * @param IContextSource $context * @param array $conditions - * @param boolean $readOnlyMode + * @param bool $readOnlyMode * @param bool|string $filterPrefix false * * @return string diff --git a/includes/pagers/EPPager.php b/includes/pagers/EPPager.php index 1db0ab4..1758c70 100644 --- a/includes/pagers/EPPager.php +++ b/includes/pagers/EPPager.php @@ -49,7 +49,7 @@ /** * Enable filtering on the conditions of the filter control. * @since 0.1 - * @var boolean + * @var bool */ protected $enableFilter = true; @@ -323,7 +323,7 @@ * * @since 0.1 * - * @param $enableFilter + * @param bool $enableFilter */ public function setEnableFilter( $enableFilter ) { $this->enableFilter = $enableFilter; @@ -334,7 +334,7 @@ * * @since 0.1 * - * @param boolean $hideWhenNoResults When true, there are no results, + * @param bool $hideWhenNoResults When true, there are no results, * and no filters are applied, an empty string is returned. * * @return string @@ -431,7 +431,7 @@ * * @since 0.1 * - * @param array $filterOptions + * @param array &$filterOptions * * @return bool If anything was changed from the default */ @@ -528,9 +528,8 @@ * @since 0.1 * * @param string $type - * @param integer $id - * - * @param $name + * @param int $id + * @param string $name * @return string */ protected function getDeletionLink( $type, $id, $name ) { diff --git a/includes/rows/Course.php b/includes/rows/Course.php index 26415f5..abd9a07 100644 --- a/includes/rows/Course.php +++ b/includes/rows/Course.php @@ -242,8 +242,8 @@ * * @since 0.4 alpha * - * @param array $fields * @param int $org_id + * @param array $fields */ protected function updateOrgSummaryFields( $org_id=null, $fields=null ) { if ( is_null( $org_id ) ) { @@ -725,15 +725,15 @@ * * @since 0.1 * - * @param array|integer $newUserIds + * @param array|int $newUserIds * @param string $role - * @param boolean $save + * @param bool $save * @param RevisionAction|null $revAction * @param array &$addedUserIds Reference to an array, for info sending * a list of the ids of users that were actually enlisted. (That is, * $newUserIds minus any that were already enlisted in this role.) * - * @return integer|bool false The amount of enlisted users or false on failiure + * @return int|bool false The amount of enlisted users or false on failiure */ public function enlistUsers( $newUserIds, @@ -819,12 +819,12 @@ * * @since 0.1 * - * @param array|integer $sadUsers + * @param array|int $sadUsers * @param string $role - * @param boolean $save + * @param bool $save * @param RevisionAction|null $revAction * - * @return integer|bool false The amount of unenlisted users or false on failiure + * @return int|bool false The amount of unenlisted users or false on failiure */ public function unenlistUsers( $sadUsers, $role, $save = true, RevisionAction $revAction = null diff --git a/includes/rows/EPRevision.php b/includes/rows/EPRevision.php index 6da7a3f..c72cf99 100644 --- a/includes/rows/EPRevision.php +++ b/includes/rows/EPRevision.php @@ -64,8 +64,8 @@ * * @since 0.1 * - * @param integer $revId - * @param integer|null $objectId + * @param int $revId + * @param int|null $objectId * * @return RevisionedObject|bool false */ diff --git a/includes/rows/RevisionedObject.php b/includes/rows/RevisionedObject.php index 5c2a478..87a3316 100644 --- a/includes/rows/RevisionedObject.php +++ b/includes/rows/RevisionedObject.php @@ -54,7 +54,7 @@ * * @since 0.1 * - * @param boolean $store + * @param bool $store */ public function setStoreRevisions( $store ) { $this->storeRevisions = $store; @@ -172,7 +172,7 @@ * @since 1.20 * * @param IORMRow $object - * @param boolean|array $excludeSummaryFields + * @param bool|array $excludeSummaryFields * When set to true, summary field changes are ignored. * Can also be an array of fields to ignore. * @@ -297,7 +297,7 @@ * * @since 0.1 * - * @param integer $id + * @param int $id * * @return EPRevision|bool false */ @@ -433,7 +433,7 @@ * * @param EPRevision $revision * @param array|null $fields - * @param boolean|null $hidePriviledgedFields If true, hide fields that + * @param bool|null $hidePriviledgedFields If true, hide fields that * only users with education program rights should see. (This is used in * Course::getCompareDiff().) * @@ -513,7 +513,7 @@ * * @since 0.1 * - * @param integer $revId + * @param int $revId * @param array|null $fields * * @return bool Success indicator @@ -528,7 +528,7 @@ * * @since 0.1 * - * @param integer $revId + * @param int $revId * @param array|null $fields * * @return bool Success indicator diff --git a/includes/rows/Student.php b/includes/rows/Student.php index 6d5d207..74a17be 100644 --- a/includes/rows/Student.php +++ b/includes/rows/Student.php @@ -94,7 +94,7 @@ * @since 0.1 * * @param IContextSource $context - * @param integer $userId + * @param int $userId * @param string $userName * * @return string diff --git a/includes/specials/SpecialAmbassadorProfile.php b/includes/specials/SpecialAmbassadorProfile.php index 66f4248..f9c6c23 100644 --- a/includes/specials/SpecialAmbassadorProfile.php +++ b/includes/specials/SpecialAmbassadorProfile.php @@ -27,7 +27,7 @@ * * @since 0.1 * - * @return boolean + * @return bool */ abstract protected function userCanAccess(); diff --git a/includes/specials/SpecialEducationProgram.php b/includes/specials/SpecialEducationProgram.php index c971adc..f7322d8 100644 --- a/includes/specials/SpecialEducationProgram.php +++ b/includes/specials/SpecialEducationProgram.php @@ -123,7 +123,7 @@ * * @since 0.1 * - * @param integer $roleId + * @param int $roleId * * @return int */ diff --git a/includes/specials/SpecialStudentActivity.php b/includes/specials/SpecialStudentActivity.php index 33db693..6ab00f1 100644 --- a/includes/specials/SpecialStudentActivity.php +++ b/includes/specials/SpecialStudentActivity.php @@ -66,7 +66,7 @@ * * @param array $conds * - * @param integer $duration + * @param int $duration * * @return string */ @@ -98,7 +98,7 @@ * @since 0.1 * * @param array $conds - * @param integer $duration + * @param int $duration * * @return string */ diff --git a/includes/specials/VerySpecialPage.php b/includes/specials/VerySpecialPage.php index 3288a1f..8321127 100644 --- a/includes/specials/VerySpecialPage.php +++ b/includes/specials/VerySpecialPage.php @@ -131,7 +131,7 @@ * @since 0.1 * * @param IORMRow $item - * @param boolean $collapsed + * @param bool $collapsed * @param array $summaryData * * @return string diff --git a/includes/tables/Courses.php b/includes/tables/Courses.php index df31899..625e7ac 100644 --- a/includes/tables/Courses.php +++ b/includes/tables/Courses.php @@ -216,7 +216,7 @@ * @since 0.1 * * @param string $state - * @param boolean $prefix + * @param bool $prefix * * @return array */ @@ -254,8 +254,8 @@ * * @since 0.1 * - * @param array|integer $userIds - * @param array|integer $roleIds + * @param array|int $userIds + * @param array|int $roleIds * @param array $conditions * @param array|string|null $fields * @param array $options diff --git a/includes/tables/Orgs.php b/includes/tables/Orgs.php index c822680..204c036 100644 --- a/includes/tables/Orgs.php +++ b/includes/tables/Orgs.php @@ -17,7 +17,7 @@ /** * @since 0.4 alpha * - * @var boolean + * @var bool */ protected $read_master_for_summaries = false; @@ -154,7 +154,7 @@ * * @since 0.4 alpha * - * @param boolean $read_master_for_summaries + * @param bool $read_master_for_summaries */ public function setReadMasterForSummaries( $read_master_for_summaries ) { $this->read_master_for_summaries = $read_master_for_summaries; diff --git a/includes/tables/PageTable.php b/includes/tables/PageTable.php index d459049..6ab50db 100644 --- a/includes/tables/PageTable.php +++ b/includes/tables/PageTable.php @@ -31,7 +31,7 @@ * * @since 0.1 * - * @return integer + * @return int */ abstract public function getNamespace(); diff --git a/maintenance/importWEPData.php b/maintenance/importWEPData.php index b3084e4..01a1908 100644 --- a/maintenance/importWEPData.php +++ b/maintenance/importWEPData.php @@ -98,7 +98,7 @@ * * @since 0.1 * - * @param array $orgs Org names as keys. Values get set to the id after insertion. + * @param array &$orgs Org names as keys. Values get set to the id after insertion. */ protected function insertOrgs( array &$orgs ) { $revAction = new RevisionAction(); diff --git a/maintenance/importWEPFromDB.php b/maintenance/importWEPFromDB.php index 634c27e..396814b 100644 --- a/maintenance/importWEPFromDB.php +++ b/maintenance/importWEPFromDB.php @@ -109,7 +109,7 @@ * Show a message. * * @param string $msg - * @param integer $level + * @param int $level */ protected function msg( $msg, $level = 1 ) { if ( $level <= $this->msgLevel ) { @@ -122,7 +122,7 @@ * Show an error. * * @param string $msg - * @param integer $level + * @param int $level */ protected function err( $msg, $level = 1 ) { $this->errors[] = $msg; @@ -244,7 +244,7 @@ /** * Inset the provided course. * - * @param integer $currentId + * @param int $currentId * @param \stdClass $course * @param string $title * @param string $term diff --git a/phpcs.xml b/phpcs.xml index 737a6bb..e2647c6 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -5,7 +5,6 @@ <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamName" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" /> - <exclude name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" /> <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" /> -- To view, visit https://gerrit.wikimedia.org/r/370821 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I526ad63486fe42e1f1dc8162e3457c8f19ee2fe8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EducationProgram Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits