jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371002 )

Change subject: Improve some parameter docs
......................................................................


Improve some parameter docs

Change-Id: I1c877b5a985d13b8a4ee04a9583833652337b31e
---
M Poem.class.php
M phpcs.xml
2 files changed, 3 insertions(+), 7 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/Poem.class.php b/Poem.class.php
index f554fe5..b366c97 100644
--- a/Poem.class.php
+++ b/Poem.class.php
@@ -6,7 +6,7 @@
 class Poem {
        /**
         * Bind the renderPoem function to the <poem> tag
-        * @param Parser $parser
+        * @param Parser &$parser
         * @return bool true
         */
        public static function init( &$parser ) {
@@ -19,7 +19,7 @@
         * @param string $in The text inside the poem tag
         * @param array $param
         * @param Parser $parser
-        * @param boolean $frame
+        * @param bool $frame
         * @return string
         */
        public static function renderPoem( $in, $param = [], $parser = null, 
$frame = false ) {
diff --git a/phpcs.xml b/phpcs.xml
index 3011e19..d1b5f11 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,12 +2,8 @@
 <ruleset>
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
        </rule>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc" />
-       <arg name="encoding" value="utf8" />
-       <exclude-pattern>vendor</exclude-pattern>
-       <exclude-pattern>node_modules</exclude-pattern>
+       <arg name="encoding" value="UTF-8" />
 </ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/371002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c877b5a985d13b8a4ee04a9583833652337b31e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Poem
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to