Jhernandez has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371048 )

Change subject: Chore: improve .gitignore accuracy
......................................................................


Chore: improve .gitignore accuracy

- npm-debug.log files seem to now be generated outside the project. The
  final comment on this [ticket] is confusing but the final [patch]
  seems to indicate that these files have legit moved and on a local
  Linux install can be seen under `~/.npm/_logs` and NPM makes reports
  like:

  npm ERR! A complete log of this run can be found in:
  npm ERR!     /home/user/.npm/_logs/2017-08-10T14_51_03_768Z-debug.log

  This patch removes the npm-debug.log entry from `.gitignore`.

- Anchor paths in `.gitignore`. If the project or its dependencies have
  generated unexpected content elsewhere, it's reasonable for Git to
  identify this.

[ticket]: https://github.com/npm/npm/issues/1548
[patch]: https://github.com/npm/npm/commit/04fca22

Change-Id: I0ca64360efc53afef6137f78c441a3ff3d1b00ce
---
M .gitignore
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Jhernandez: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
index 7c5b92b..cc167a6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,7 +1,6 @@
 # Compiled assets
-dist/
+/dist/
 
 # Node
-npm-debug.log*
-node_modules/
-.eslintcache
+/node_modules/
+/.eslintcache

-- 
To view, visit https://gerrit.wikimedia.org/r/371048
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ca64360efc53afef6137f78c441a3ff3d1b00ce
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to