Jhernandez has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/371040 )
Change subject: Fix: observe project root not removable directories ...................................................................... Fix: observe project root not removable directories It seems that replaced watched directories cannot be observed by nodemon. The recommended [workaround] is to watch the parent. This patch changes the files monitored to the package root less ignored files (.git|node_modules) so that any change has the expected effect. The output prior to this change was approximately: $ DEBUG=nodemon,nodemon:\* npm start ... nodemon start watch on: dist/client +0ms nodemon start watch on: /home/stephen/dev/wmf/marvin/dist/client +0ms ... clean-webpack-plugin: /home/stephen/dev/wmf/marvin/dist/client has been removed. ... [workaround]: https://github.com/paulmillr/chokidar/issues/555 Change-Id: I5d84a8e65141fe46db9750dcd09ce7c23dfc6600 --- M package.json 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jhernandez: Verified; Looks good to me, approved diff --git a/package.json b/package.json index 1356247..a2eb893 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "scripts": { "start": "run-p -sn dev:\\*", "dev:client": "NODE_ENV=development webpack -w", - "dev:server": "NODE_ENV=development nodemon -q -w dist/client -w src/server/ src/server/index.js", + "dev:server": "NODE_ENV=development nodemon -q src/server/index.js", "prod:build": "NODE_ENV=production webpack -p", "format": "npm run lint -s -- --fix", "format:all": "npm run format -s -- .", -- To view, visit https://gerrit.wikimedia.org/r/371040 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d84a8e65141fe46db9750dcd09ce7c23dfc6600 Gerrit-PatchSet: 2 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
