jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369718 )

Change subject: Remove one likely unneeded & unwanted call to Database#commit
......................................................................


Remove one likely unneeded & unwanted call to Database#commit

This resulted in stuff like this being logged to the DB error log:
RefreshSpecialForm::refreshSpecial: Explicit commit of implicit
transaction.

Not to mention that the core maintenance script updateSpecialPages.php, on
which this extension is based, doesn't call Database#commit or even
Database#endAtomic anywhere anymore.

Change-Id: Id7ccddba8f3474388b6d816976943edc65b2aa21
---
M RefreshSpecial.body.php
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/RefreshSpecial.body.php b/RefreshSpecial.body.php
index 0260e3d..24e9407 100644
--- a/RefreshSpecial.body.php
+++ b/RefreshSpecial.body.php
@@ -289,9 +289,6 @@
                                                        sleep( 
RefreshSpecial::RECONNECTION_SLEEP );
                                                } while ( !wfGetLB()->pingAll() 
);
                                                $out->addHTML( $this->msg( 
'refreshspecial-reconnected' )->plain() . '<br /><br />' );
-                                       } else {
-                                               # Commit the results
-                                               $dbw->commit( __METHOD__ );
                                        }
 
                                        # Wait for the slave to catch up

-- 
To view, visit https://gerrit.wikimedia.org/r/369718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7ccddba8f3474388b6d816976943edc65b2aa21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RefreshSpecial
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to