jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371099 )
Change subject: Replace abandoned color with current WikimediaUI one
......................................................................
Replace abandoned color with current WikimediaUI one
Replacing abandoned `@colorGray13` (`#ddd`) with
appropriate variable from WikimediaUI color palette and
remove unneeded `@chromeContentSeparator` var, which is
just used once and not in place with `.header` anyways.
Additional changes:
* Also aligning `border` values to each other.
Bug: T146799
Bug: T172850
Change-Id: Ia9a1736b1ea5fa080b4673038b2c23ddce90f135
---
M minerva.less/minerva.variables.less
M resources/skins.minerva.base.styles/ui.less
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/minerva.less/minerva.variables.less
b/minerva.less/minerva.variables.less
index bd6f448..89d83e3 100644
--- a/minerva.less/minerva.variables.less
+++ b/minerva.less/minerva.variables.less
@@ -34,7 +34,6 @@
// colors
@chromeColor: @grayLightest;
-@chromeContentSeparator: @colorGray13;
@semiTransparent: rgba( 0, 0, 0, 0.8 );
@linkColor: #002bb8;
diff --git a/resources/skins.minerva.base.styles/ui.less
b/resources/skins.minerva.base.styles/ui.less
index b501a33..b17320e 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -16,7 +16,7 @@
// FIXME: should we use .mw-body here instead?
#content {
// avoid margin collapsing (see T147956)
- border-top: solid 1px transparent;
+ border-top: 1px solid transparent;
padding-bottom: 32px;
}
@@ -26,7 +26,7 @@
}
.header-container {
- border-bottom: solid 1px @chromeContentSeparator;
+ border-bottom: 1px solid @colorGray13;
&.header-chrome {
background-color: @chromeColor;
@@ -246,7 +246,7 @@
.section-heading {
width: 100%;
- border-bottom: solid 1px @colorGray14;
+ border-bottom: 1px solid @colorGray14;
margin-bottom: @headingMargin;
.indicator {
--
To view, visit https://gerrit.wikimedia.org/r/371099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a1736b1ea5fa080b4673038b2c23ddce90f135
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
