jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371116 )

Change subject: Reduce confusion for mw.util.getUrl()
......................................................................


Reduce confusion for mw.util.getUrl()

Currently, `this` is passed as the parameter for pageName, making it
seem like getUrl() can take in an object as the first parameter, when
it should be a string. This works right now because of a tertiary
operator that fetches what we need. To reduce confusion, we should
pass null instead.

Change-Id: Ieea30a4933f3e3fdeb8331c5c544bf1eb034e6b7
---
M modules/ext.RevisionSlider.RevisionListView.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  WMDE-Fisch: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.RevisionSlider.RevisionListView.js 
b/modules/ext.RevisionSlider.RevisionListView.js
index df9d0a7..7f00e92 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -242,7 +242,7 @@
                                .append(
                                        $( '<p>' ).append(
                                                $( '<strong>' ).text( mw.msg( 
'revisionslider-label-date' ) + mw.msg( 'colon-separator' ) ),
-                                               $( '<a>' ).attr( 'href', 
mw.util.getUrl( this, { oldid: revision.id } ) )
+                                               $( '<a>' ).attr( 'href', 
mw.util.getUrl( null, { oldid: revision.id } ) )
                                                        .text( 
revision.getFormattedDate() )
                                        ),
                                        this.makeUserLine( revision.getUser(), 
revision.getUserGender() ),

-- 
To view, visit https://gerrit.wikimedia.org/r/371116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieea30a4933f3e3fdeb8331c5c544bf1eb034e6b7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: MtDu <justin.d...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to