jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371120 )

Change subject: Replace abandoned `@colorGray13` with current WikimediaUI one
......................................................................


Replace abandoned `@colorGray13` with current WikimediaUI one

Replacing abandoned `@colorGray13` (`#ddd`) with
appropriate variable `colorGray12` (`#c8ccd1`) from WikimediaUI
color palette, which is used for borders elsewhere.

Additional changes:
* Also minor cleanup of CSS properties

Bug: T146799
Bug: T172850
Change-Id: Ic040612c550a0e131832702af642bf1c77540ed8
---
M resources/mobile.categories.overlays/categories.less
M resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
M resources/mobile.special.pagefeed.styles/pagefeed.less
M skinStyles/mobile.editor.ve/minerva.less
4 files changed, 14 insertions(+), 12 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mobile.categories.overlays/categories.less 
b/resources/mobile.categories.overlays/categories.less
index d0225b7..247e55f 100644
--- a/resources/mobile.categories.overlays/categories.less
+++ b/resources/mobile.categories.overlays/categories.less
@@ -12,12 +12,13 @@
 
        li {
                display: inline-block;
-               border-left: 1px solid @colorGray13;
                margin: 0 0 0 -1px;
-               border-bottom: 1px solid @colorGray13;
-               text-align: center;
-               line-height: 1.5;
+               border-width: 0 0 1px 1px;
+               border-style: solid;
+               border-color: @colorGray12;
                padding: 5px 0 0;
+               line-height: 1.5;
+               text-align: center;
 
                a {
                        display: block;
@@ -27,7 +28,7 @@
                }
 
                &.selected a {
-                       border-bottom: solid 3px @colorProgressive;
+                       border-bottom-color: @colorProgressive;
                        font-weight: bold;
                }
        }
diff --git 
a/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less 
b/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
index 12681fc..30f7bc2 100644
--- 
a/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
+++ 
b/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
@@ -21,7 +21,7 @@
 
                .mw-echo-ui-pageNotificationsOptionWidget {
                        .box-sizing( border-box );
-                       border: 1px solid @colorGray13;
+                       border: 1px solid @colorGray12;
                        padding: 0.7em 1.5em 1em 1em;
                        width: 100%;
                }
@@ -31,7 +31,7 @@
                }
 
                .mw-echo-ui-crossWikiUnreadFilterWidget {
-                       border: 1px solid @colorGray13;
+                       border: 1px solid @colorGray12;
                        width: 100%;
                        margin-left: 0;
                        padding: 0;
diff --git a/resources/mobile.special.pagefeed.styles/pagefeed.less 
b/resources/mobile.special.pagefeed.styles/pagefeed.less
index 58706b2..d5671d6 100644
--- a/resources/mobile.special.pagefeed.styles/pagefeed.less
+++ b/resources/mobile.special.pagefeed.styles/pagefeed.less
@@ -25,9 +25,9 @@
 .page-header-bar {
        li,
        div {
-               line-height: 1.5;
+               border-bottom: 1px solid @colorGray12;
                padding: 5px 0 0;
-               border-bottom: 1px solid @colorGray13;
+               line-height: 1.5;
                text-align: center;
        }
 }
@@ -37,9 +37,9 @@
 
        li {
                display: inline-block;
-               border-left: 1px solid @colorGray13;
                width: 25%;
                margin: 0 0 0 -1px;
+               border-left: 1px solid @colorGray12;
                border-bottom: 0;
 
                &:first-child {
@@ -55,7 +55,7 @@
                }
 
                &.selected a {
-                       border-bottom: solid 3px @colorProgressive;
+                       border-bottom-color: @colorProgressive;
                        font-weight: bold;
                }
                /* stylelint-enable no-descending-specificity */
diff --git a/skinStyles/mobile.editor.ve/minerva.less 
b/skinStyles/mobile.editor.ve/minerva.less
index ef88295..5e10e88 100644
--- a/skinStyles/mobile.editor.ve/minerva.less
+++ b/skinStyles/mobile.editor.ve/minerva.less
@@ -88,7 +88,8 @@
 
                .ve-init-mw-mobileArticleTarget-toolbar {
                        @media all and ( min-width: @wgMFDeviceWidthDesktop ) {
-                               border: 1px solid @colorGray13;
+                               border-color: @colorGray12;
+                               border-style: solid;
                                border-width: 0 1px;
                        }
                        // Everything is measured in ems so the easiest way to 
scale

-- 
To view, visit https://gerrit.wikimedia.org/r/371120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic040612c550a0e131832702af642bf1c77540ed8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to