jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363358 )

Change subject: Fix Newsletter publisher name not showing up correctly on 
Manage page.
......................................................................


Fix Newsletter publisher name not showing up correctly on Manage page.

Bug: T169421
Change-Id: Icd1a1e8c89bee3c3b824a1e264ad0c9c3ea050e2
---
M includes/NewsletterEditPage.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Looks good to me, approved
  MtDu: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/NewsletterEditPage.php b/includes/NewsletterEditPage.php
index 838cf18..23d5b87 100644
--- a/includes/NewsletterEditPage.php
+++ b/includes/NewsletterEditPage.php
@@ -128,7 +128,7 @@
                        'type' => 'usersmultiselect',
                        'label-message' => 'newsletter-manage-publishers',
                        'exists' => true,
-                       'default' => $publishersNames,
+                       'default' => implode( "\n", $publishersNames ),
                ];
                $fields['Summary'] = [
                        'type' => 'text',
@@ -372,7 +372,7 @@
                        $modified = true;
                }
 
-               $publisherNames = $data['Publishers'];
+               $publisherNames = explode( "\n", $data['Publishers'] );
                // Ask for confirmation before removing all the publishers
                if ( !$confirmed && count( $publisherNames ) === 0 ) {
                        return Status::newFatal( 
'newsletter-manage-no-publishers' );

-- 
To view, visit https://gerrit.wikimedia.org/r/363358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1a1e8c89bee3c3b824a1e264ad0c9c3ea050e2
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Phantom42 <nikita...@gmail.com>
Gerrit-Reviewer: 01tonythomas <01tonytho...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: MtDu <justin.d...@gmail.com>
Gerrit-Reviewer: Phantom42 <nikita...@gmail.com>
Gerrit-Reviewer: Qgil <q...@wikimedia.org>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to