Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371361 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
......................................................................

build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ExtraParamComment
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.MissingReturnType
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle

The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment

Change-Id: Id02948f1792ba89982fee6af7721e25aa1163a21
---
M composer.json
M nova/OpenStackNovaController.php
M nova/OpenStackNovaSudoer.php
M phpcs.xml
M special/SpecialNovaProxy.php
M special/SpecialNovaServiceGroup.php
6 files changed, 19 insertions(+), 10 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager 
refs/changes/61/371361/1

diff --git a/composer.json b/composer.json
index ea7fb13..279f59a 100644
--- a/composer.json
+++ b/composer.json
@@ -5,7 +5,7 @@
        "require-dev": {
                "jakub-onderka/php-parallel-lint": "0.9.2",
                "jakub-onderka/php-console-highlighter": "0.3.2",
-               "mediawiki/mediawiki-codesniffer": "0.10.1"
+               "mediawiki/mediawiki-codesniffer": "0.11.0"
        },
        "scripts": {
                "fix": "phpcbf",
diff --git a/nova/OpenStackNovaController.php b/nova/OpenStackNovaController.php
index f81e007..0e7aebe 100644
--- a/nova/OpenStackNovaController.php
+++ b/nova/OpenStackNovaController.php
@@ -944,7 +944,7 @@
         * Delete a Nova volume
         *
         * @param  $volumeid
-        * @return boolean
+        * @return bool
         */
        function deleteVolume( $volumeid ) {
                # unimplemented
@@ -957,7 +957,7 @@
         * @param volumeid
         * @param instanceid
         * @param device
-        * @return boolean
+        * @return bool
         */
        function attachVolume( $volumeid, $instanceid, $device ) {
                # unimplemented
@@ -969,7 +969,7 @@
         *
         * @param volumeid
         * @param force
-        * @return boolean
+        * @return bool
         */
        function detachVolume( $volumeid, $force ) {
                # unimplemented
@@ -981,7 +981,7 @@
         *
         * @param type
         * @param string $type
-        * @return boolean
+        * @return bool
         */
        function rebootInstance( $instanceid, $type='SOFT' ) {
                $instanceid = urlencode( $instanceid );
diff --git a/nova/OpenStackNovaSudoer.php b/nova/OpenStackNovaSudoer.php
index 08a4b7f..812481e 100644
--- a/nova/OpenStackNovaSudoer.php
+++ b/nova/OpenStackNovaSudoer.php
@@ -133,7 +133,7 @@
         * @param  $users
         * @param  $commands
         * @param  $options
-        * @return boolean
+        * @return bool
         */
        function modifySudoer( $users, $runasuser, $commands, $options ) {
                global $wgMemc;
diff --git a/phpcs.xml b/phpcs.xml
index 6ff27fb..17713f8 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,10 +1,19 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ruleset>
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.ExtraParamComment" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingReturnType" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+               <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" 
/>
                <exclude name="PSR2.Methods.MethodDeclaration.Underscore"/>
                <exclude 
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName"/>
                <exclude 
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
-               <exclude name="MediaWiki.Commenting.FunctionComment"/>
        </rule>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc"/>
diff --git a/special/SpecialNovaProxy.php b/special/SpecialNovaProxy.php
index d150f8d..47c58b3 100644
--- a/special/SpecialNovaProxy.php
+++ b/special/SpecialNovaProxy.php
@@ -357,7 +357,7 @@
                        $this->msg( 'openstackmanager-backproxylist' 
)->escaped()
                );
 
-               $success =  $this->userNova->deleteProxy( $fqdn );
+               $success = $this->userNova->deleteProxy( $fqdn );
                if ( $success ) {
                        $success = $this->deleteHost( $fqdn, 
$wgOpenStackManagerProxyGateways[$region] );
                        if ( !$success ) {
@@ -416,7 +416,7 @@
                }
 
                # DNS looks good, now we can set up the proxy.
-               $newProxy =  $this->userNova->createProxy( $fqdn, $backendHost, 
$backendPort );
+               $newProxy = $this->userNova->createProxy( $fqdn, $backendHost, 
$backendPort );
 
                if ( $newProxy ) {
                        $outputPage->addWikiMsg(
diff --git a/special/SpecialNovaServiceGroup.php 
b/special/SpecialNovaServiceGroup.php
index fcafc0f..5b2dd67 100644
--- a/special/SpecialNovaServiceGroup.php
+++ b/special/SpecialNovaServiceGroup.php
@@ -267,7 +267,7 @@
        function getServiceGroups( $project ) {
                $project->fetchProjectInfo();
                $projectName = $project->getProjectName();
-               $serviceGroups =  $project->getServiceGroups();
+               $serviceGroups = $project->getServiceGroups();
                if ( $serviceGroups ) {
                        $headers = [
                                'openstackmanager-servicegroupname',

-- 
To view, visit https://gerrit.wikimedia.org/r/371361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id02948f1792ba89982fee6af7721e25aa1163a21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to