Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371365 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
......................................................................

build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ib7e3cf69729de7e04821a666db69b56622095721
---
M api/ApiPageTriageList.php
M api/ApiPageTriageStats.php
M composer.json
M includes/ArticleMetadata.php
M includes/PageTriageUtil.php
M tests/phpunit/ArticleMetadataTest.php
M tests/phpunit/SpecialNewPagesFeedTest.php
7 files changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/65/371365/1

diff --git a/api/ApiPageTriageList.php b/api/ApiPageTriageList.php
index b874870..8f773d4 100644
--- a/api/ApiPageTriageList.php
+++ b/api/ApiPageTriageList.php
@@ -280,10 +280,10 @@
                        'showredirs' => [
                                ApiBase::PARAM_TYPE => 'boolean',
                        ],
-                       'showreviewed'=> [
+                       'showreviewed' => [
                                ApiBase::PARAM_TYPE => 'boolean',
                        ],
-                       'showunreviewed'=> [
+                       'showunreviewed' => [
                                ApiBase::PARAM_TYPE => 'boolean',
                        ],
                        'showdeleted' => [
diff --git a/api/ApiPageTriageStats.php b/api/ApiPageTriageStats.php
index 759e7e8..228b46d 100644
--- a/api/ApiPageTriageStats.php
+++ b/api/ApiPageTriageStats.php
@@ -35,10 +35,10 @@
                        'showredirs' => [
                                ApiBase::PARAM_TYPE => 'boolean',
                        ],
-                       'showreviewed'=> [
+                       'showreviewed' => [
                                ApiBase::PARAM_TYPE => 'boolean',
                        ],
-                       'showunreviewed'=> [
+                       'showunreviewed' => [
                                ApiBase::PARAM_TYPE => 'boolean',
                        ],
                        'showdeleted' => [
diff --git a/composer.json b/composer.json
index 91c6304..eff2a81 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
        "require-dev": {
                "jakub-onderka/php-parallel-lint": "0.9.2",
-               "mediawiki/mediawiki-codesniffer": "0.10.1",
+               "mediawiki/mediawiki-codesniffer": "0.11.0",
                "jakub-onderka/php-console-highlighter": "0.3.2"
        },
        "scripts": {
diff --git a/includes/ArticleMetadata.php b/includes/ArticleMetadata.php
index 5356849..739251d 100755
--- a/includes/ArticleMetadata.php
+++ b/includes/ArticleMetadata.php
@@ -380,7 +380,7 @@
        public function configComponentDb( $config ) {
                $dbMode = [ DB_MASTER, DB_SLAVE ];
                foreach ( $this->componentDb as $key => $value ) {
-                       if ( isset ( $config[$key] ) && in_array( 
$config[$key], $dbMode ) ) {
+                       if ( isset( $config[$key] ) && in_array( $config[$key], 
$dbMode ) ) {
                                $this->componentDb[$key] = $config[$key];
                        }
                }
@@ -491,7 +491,7 @@
                // Loop through old metadata value and compare them with the 
new one,
                // if they are the same, remove them from $newData
                foreach ( $res as $row ) {
-                       if ( isset ( 
$newData[$row->ptrpt_page_id][$row->ptrt_tag_name] )
+                       if ( isset( 
$newData[$row->ptrpt_page_id][$row->ptrt_tag_name] )
                                && 
$newData[$row->ptrpt_page_id][$row->ptrt_tag_name] == $row->ptrpt_value
                        ) {
                                unset( 
$newData[$row->ptrpt_page_id][$row->ptrt_tag_name] );
@@ -644,7 +644,7 @@
 
        protected function getParserOutputByPageId( $pageId ) {
                // Prefer a preregistered LinksUpdate
-               if ( isset ( $this->linksUpdates[$pageId] ) ) {
+               if ( isset( $this->linksUpdates[$pageId] ) ) {
                        return $this->linksUpdates[$pageId]->getParserOutput();
                }
                // Fall back on Article
diff --git a/includes/PageTriageUtil.php b/includes/PageTriageUtil.php
index da67e22..0640f78 100755
--- a/includes/PageTriageUtil.php
+++ b/includes/PageTriageUtil.php
@@ -185,8 +185,8 @@
                // times to look back for top trigers and expiration time in 
cache
                $timeFrame = [
                                'last-day' => [ 'ts' => $now - 24 * 60 * 60, 
'expire' => 60 * 60 ],
-                               'last-week' => [ 'ts' => $now - 7 * 24 * 60 * 
60, 'expire' =>  24 * 60 * 60 ],
-                               'last-month' => [ 'ts' => $now - 30 * 24 * 60 * 
60, 'expire' =>  24 * 60 * 60 ],
+                               'last-week' => [ 'ts' => $now - 7 * 24 * 60 * 
60, 'expire' => 24 * 60 * 60 ],
+                               'last-month' => [ 'ts' => $now - 30 * 24 * 60 * 
60, 'expire' => 24 * 60 * 60 ],
                ];
 
                if ( !isset( $timeFrame[$time] ) ) {
diff --git a/tests/phpunit/ArticleMetadataTest.php 
b/tests/phpunit/ArticleMetadataTest.php
index bea0815..e0a9068 100644
--- a/tests/phpunit/ArticleMetadataTest.php
+++ b/tests/phpunit/ArticleMetadataTest.php
@@ -21,7 +21,7 @@
                // Set up some page_id to test
                $count = $start = 0;
                while ( $count < 6 ) {
-                       $res =  $this->dbr->selectRow(
+                       $res = $this->dbr->selectRow(
                                                [ 'page', 'pagetriage_page' ],
                                                [ 'page_id' ],
                                                [
diff --git a/tests/phpunit/SpecialNewPagesFeedTest.php 
b/tests/phpunit/SpecialNewPagesFeedTest.php
index c3f4a2c..79c57be 100644
--- a/tests/phpunit/SpecialNewPagesFeedTest.php
+++ b/tests/phpunit/SpecialNewPagesFeedTest.php
@@ -87,7 +87,7 @@
 
                $alreadyCreated = false;
                try {
-                       list( $result, , $session ) =  
$this->doApiRequestWithToken(
+                       list( $result, , $session ) = 
$this->doApiRequestWithToken(
                                $params,
                                $sessionArray['one'],
                                self::$users['one']->getUser()

-- 
To view, visit https://gerrit.wikimedia.org/r/371365
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7e3cf69729de7e04821a666db69b56622095721
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to