jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371288 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
......................................................................


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I0db3113435b315d4f2c778e4e9a45e4eb896aa43
---
M composer.json
M phpcs.xml
M src/Hooks.php
M src/TextFileImporter.php
4 files changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 99b25c3..783f1e0 100644
--- a/composer.json
+++ b/composer.json
@@ -14,7 +14,7 @@
        },
        "require-dev": {
                "jakub-onderka/php-parallel-lint": "^0.9",
-               "mediawiki/mediawiki-codesniffer": "^0.9",
+               "mediawiki/mediawiki-codesniffer": "0.11.0",
                "jakub-onderka/php-console-highlighter": "0.3.2"
        },
        "scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index a6380ce..aeffe15 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0"?>
 <ruleset name="MediaWiki">
-       <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+       <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+       </rule>
        <file>.</file>
        <exclude-pattern>vendor</exclude-pattern>
 </ruleset>
diff --git a/src/Hooks.php b/src/Hooks.php
index 1eaef47..0ed507f 100644
--- a/src/Hooks.php
+++ b/src/Hooks.php
@@ -16,7 +16,7 @@
         * @global array $eagRules ExternalArticles configuration array
         * @param string &$text Text with which to prefill the edit form
         * @param Title &$title Title of the new page
-        * @return boolean
+        * @return bool
         */
        function onEditFormPreloadText( &$text, Title &$title ) {
                global $wgOut, $wgEagRules;
diff --git a/src/TextFileImporter.php b/src/TextFileImporter.php
index 26c9178..7ba903f 100644
--- a/src/TextFileImporter.php
+++ b/src/TextFileImporter.php
@@ -22,7 +22,7 @@
        /**
         * Import text files from a directory.
         * @param string $dir The directory to import from.
-        * @param boolean $watch Whether to continue to watch the files for 
changes.
+        * @param bool $watch Whether to continue to watch the files for 
changes.
         * @throws Exception If the directory does not exist.
         */
        public function __construct( $dir, $watch ) {
@@ -30,7 +30,7 @@
                        throw new Exception( "'$dir' is not a directory" );
                }
                $this->dir = realpath( $dir );
-               $this->watch = (boolean)$watch && function_exists( 
'inotify_init' );
+               $this->watch = (bool)$watch && function_exists( 'inotify_init' 
);
                if ( $this->watch ) {
                        $this->inotify = inotify_init();
                }
@@ -73,7 +73,7 @@
        /**
         * Import a single file.
         * @param string $file Full filesystem path to the file to import.
-        * @return boolean
+        * @return bool
         */
        protected function importFile( $file ) {
                // Construct the page name from the last components of the file 
path.

-- 
To view, visit https://gerrit.wikimedia.org/r/371288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0db3113435b315d4f2c778e4e9a45e4eb896aa43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ExternalArticles
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to